Re: [PATCH v1] dt-bindings: riscv: deprecate riscv,isa

From: Rob Herring <robh@kernel.org>
To: Conor Dooley <conor@kernel.org>
Cc: Conor Dooley <conor.dooley@microchip.com>,
	Sean Anderson <sean.anderson@seco.com>,
	 Anup Patel <anup@brainfault.org>,
	Andrew Jones <ajones@ventanamicro.com>,
	palmer@dabbelt.com,  Paul Walmsley <paul.walmsley@sifive.com>,
	 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	 Alistair Francis <alistair.francis@wdc.com>,
	Anup Patel <apatel@ventanamicro.com>,
	 Atish Patra <atishp@atishpatra.org>,
	Jessica Clarke <jrtc27@jrtc27.com>,
	 Rick Chen <rick@andestech.com>, Leo <ycliang@andestech.com>,
	 linux-riscv@lists.infradead.org, qemu-riscv@nongnu.org,
	u-boot@lists.denx.de,  devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] dt-bindings: riscv: deprecate riscv,isa
Date: Tue, 13 Jun 2023 07:28:34 -0600	[thread overview]
Message-ID: <CAL_Jsq+CJ-mEcEujd5Sk4SLvgTfUX1A7NRXYcMDqkoViDYxTXw@mail.gmail.com> (raw)
In-Reply-To: <20230612-relic-fetal-1beeae3455aa@spud>

On Mon, Jun 12, 2023 at 3:23 PM Conor Dooley <conor@kernel.org> wrote:
>
> Rob,
> Before I press on with more versions...
>
> On Thu, Jun 08, 2023 at 08:30:28PM +0100, Conor Dooley wrote:
> > On Thu, Jun 08, 2023 at 01:15:37PM -0600, Rob Herring wrote:
> > > On Tue, May 30, 2023 at 03:12:12PM +0100, Conor Dooley wrote:
> > > > On Thu, May 18, 2023 at 10:42:34PM +0100, Conor Dooley wrote:
> > > > > On Thu, May 18, 2023 at 02:30:53PM -0400, Sean Anderson wrote:
> > > >
> > > > > >
> > > > > > Why not just have something like
> > > > > >
> > > > > > mycpu {
> > > > > >       ...
> > > > > >       riscv,isa {
> > > > > >               i;
> > > > > >               m;
> > > > > >               a;
> > > > > >               zicsr;
> > > > > >               ...
> > >
> > > I prefer property names be globally unique. The tools are geared towards
> > > that too. That's largely a symptom of having 0 type information in the
> > > DT.
> > >
> > > For example if you had an extension called 'reg', it would be a problem.
> >
> > Per the current ISA rules, that'd not be valid. But then again, I do
> > have trust issues & it's not like "reg" is the only property name in DT
> > land.
>
> ...you say "prefer" here. Is that a NAK, or a "you keep the pieces"?

Don't do the above node.

Rob

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv