From: Pragnesh Patel <pragnesh.patel@sifive.com>
To: Green Wan <green.wan@sifive.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Linus Walleij <linus.walleij@linaro.org>,
Palmer Dabbelt <palmer@sifive.com>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org,
Vinod Koul <vkoul@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
linux-hackers@sifive.com, linux-riscv@lists.infradead.org,
"Paul E. McKenney" <paulmck@linux.ibm.com>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH v3 1/3] dt-bindings: dmaengine: sf-pdma: add bindins for SiFive PDMA
Date: Fri, 20 Sep 2019 15:31:35 +0530 [thread overview]
Message-ID: <CAN8ut8Lfo3zm2mjoiH3o4FSTkHexagwUFT=V3MpgcE=arm5c4g@mail.gmail.com> (raw)
In-Reply-To: <20190920090033.19438-1-green.wan@sifive.com>
On Fri, Sep 20, 2019 at 2:30 PM Green Wan <green.wan@sifive.com> wrote:
>
> Add DT bindings document for Platform DMA(PDMA) driver of board,
> HiFive Unleashed Rev A00.
>
> Signed-off-by: Green Wan <green.wan@sifive.com>
> ---
> .../bindings/dma/sifive,fu540-c000-pdma.yaml | 55 +++++++++++++++++++
> MAINTAINERS | 5 ++
> 2 files changed, 60 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/dma/sifive,fu540-c000-pdma.yaml
>
> diff --git a/Documentation/devicetree/bindings/dma/sifive,fu540-c000-pdma.yaml b/Documentation/devicetree/bindings/dma/sifive,fu540-c000-pdma.yaml
> new file mode 100644
> index 000000000000..3ed015f2b83a
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/dma/sifive,fu540-c000-pdma.yaml
> @@ -0,0 +1,55 @@
> +# SPDX-License-Identifier: GPL-2.0
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/dma/sifive,fu540-c000-pdma.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: SiFive Unleashed Rev C000 Platform DMA
> +
> +maintainers:
> + - Green Wan <green.wan@sifive.com>
> + - Palmer Debbelt <palmer@sifive.com>
> + - Paul Walmsley <paul.walmsley@sifive.com>
> +
> +description: |
> + Platform DMA is a DMA engine of SiFive Unleashed. It supports 4
> + channels. Each channel has 2 interrupts. One is for DMA done and
> + the other is for DME error.
> +
> + In different SoC, DMA could be attached to different IRQ line.
> + DT file need to be changed to meet the difference. For technical
> + doc,
> +
> + https://static.dev.sifive.com/FU540-C000-v1.0.pdf
> +
> +properties:
> + compatible:
> + items:
> + - const: sifive,fu540-c000-pdma
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + minItems: 8
> + maxItems: 8
"make dt_binding_check" should give you the error that interrupts is too short.
When you say minItems: 8 then interrupts property should be like this:
interrupts = <23>, <24>, <25>, <26>, <27>, <28>, <29>, <30>;
So, remove the minItems: 8 and change maxItems: 1 for interrupts =
<23 24 25 26 27 28 29 30>;
> +
> + '#dma-cells':
> + const: 1
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - '#dma-cells'
> +
> +examples:
> + - |
> + dma@3000000 {
> + compatible = "sifive,fu540-c000-pdma";
> + reg = <0x0 0x3000000 0x0 0x8000>;
> + interrupts = <23 24 25 26 27 28 29 30>;
> + #dma-cells = <1>;
> + };
> +
> +...
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 49f75d1b7b51..d0caa09a479e 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -14591,6 +14591,11 @@ F: drivers/media/usb/siano/
> F: drivers/media/usb/siano/
> F: drivers/media/mmc/siano/
>
> +SIFIVE PDMA DRIVER
> +M: Green Wan <green.wan@sifive.com>
> +S: Maintained
> +F: Documentation/devicetree/bindings/dma/sifive,fu540-c000-pdma.yaml
> +
> SIFIVE DRIVERS
> M: Palmer Dabbelt <palmer@sifive.com>
> M: Paul Walmsley <paul.walmsley@sifive.com>
> --
> 2.17.1
>
> --
> You received this message because you are subscribed to the Google Groups "linux-hackers" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to linux-hackers+unsubscribe@sifive.com.
> To view this discussion on the web visit https://groups.google.com/a/sifive.com/d/msgid/linux-hackers/20190920090033.19438-1-green.wan%40sifive.com.
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
prev parent reply other threads:[~2019-09-20 10:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-20 9:00 [PATCH v3 1/3] dt-bindings: dmaengine: sf-pdma: add bindins for SiFive PDMA Green Wan
2019-09-20 10:01 ` Pragnesh Patel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAN8ut8Lfo3zm2mjoiH3o4FSTkHexagwUFT=V3MpgcE=arm5c4g@mail.gmail.com' \
--to=pragnesh.patel@sifive.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=green.wan@sifive.com \
--cc=gregkh@linuxfoundation.org \
--cc=linus.walleij@linaro.org \
--cc=linux-hackers@sifive.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=mchehab+samsung@kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=palmer@sifive.com \
--cc=paul.walmsley@sifive.com \
--cc=paulmck@linux.ibm.com \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).