From: Thierry Reding <thierry.reding@gmail.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>,
Heiko Stuebner <heiko@sntech.de>,
Guenter Roeck <groeck@chromium.org>,
linux-riscv@lists.infradead.org, chrome-platform@lists.linux.dev,
Florian Fainelli <florian.fainelli@broadcom.com>,
linux-staging@lists.linux.dev,
linux-rockchip@lists.infradead.org,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
linux-pwm@vger.kernel.org, Ray Jui <rjui@broadcom.com>,
Johan Hovold <johan@kernel.org>,
greybus-dev@lists.linaro.org,
Paul Walmsley <paul.walmsley@sifive.com>,
Benson Leung <bleung@chromium.org>,
linux-arm-kernel@lists.infradead.org,
Alex Elder <elder@kernel.org>,
Scott Branden <sbranden@broadcom.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
Michael Walle <michael@walle.cc>,
Palmer Dabbelt <palmer@dabbelt.com>,
kernel@pengutronix.de,
Claudiu Beznea <claudiu.beznea@microchip.com>
Subject: Re: [PATCH 00/10] pwm: Constistenly name pwm_chip variables "chip"
Date: Thu, 20 Jul 2023 17:03:07 +0200 [thread overview]
Message-ID: <ZLlMqwAnoPzI8ONt@orome> (raw)
In-Reply-To: <20230720071033.e72hjkpghf5ooe73@pengutronix.de>
[-- Attachment #1.1: Type: text/plain, Size: 2074 bytes --]
On Thu, Jul 20, 2023 at 09:10:33AM +0200, Uwe Kleine-König wrote:
> Hello Thierry,
>
> On Thu, Jul 20, 2023 at 08:48:11AM +0200, Thierry Reding wrote:
> > On Fri, Jul 14, 2023 at 10:56:13PM +0200, Uwe Kleine-König wrote:
> > > Uwe Kleine-König (10):
> > > pwm: Use a consistent name for pwm_chip pointers in the core
> > > pwm: atmel-hlcdc: Use consistent variable naming
> > > pwm: bcm-kona: Consistenly name pwm_chip variables "chip"
> > > pwm: crc: Consistenly name pwm_chip variables "chip"
> > > pwm: cros-ec: Consistenly name pwm_chip variables "chip"
> > > pwm: lp3943: Consistenly name pwm_chip variables "chip"
> > > pwm: rockchip: Consistenly name pwm_chip variables "chip"
> > > pwm: sifive: Consistenly name pwm_chip variables "chip"
> > > pwm: sl28cpld: Consistenly name pwm_chip variables "chip"
> > > staging: greybus: pwm: Consistenly name pwm_chip variables "chip"
> >
> > This would've been much easier if it had been a single patch. Now I have
> > to either make you redo the whole series because you've misspelled PWM
> > or I have to go and update it myself in most of the above patches. Hint:
> > I'll do the latter.
>
> I guess you want to do s/pwm driver/PWM driver/? Fine for me, thanks.
>
> > There is really no reason to split this up into this many patches for
> > such a trivial change.
>
> Well, that's a subjective view. There are reasons to prefer several
> small patches over one big one, too. A small patch can be indiviually
> reviewed, so the "Reviewed-by: Alex Elder ..." tag only goes to the one
> change that he actually looked at and if later a fix to the sifive
> driver is to be backported to stable, the stable maintainers just pick
> the sifive one instead of one big patch.
Backports becoming more complicated would actually be a good reason not
to do this in the first place, but we've already discussed that enough
elsewhere.
> Did you skip the sl28cpld patch, or squash the fixup I sent in the reply
> to Michael Walle?
I squashed the fixup.
Thierry
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 161 bytes --]
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2023-07-20 15:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-14 20:56 [PATCH 00/10] pwm: Constistenly name pwm_chip variables "chip" Uwe Kleine-König
2023-07-14 20:56 ` [PATCH 08/10] pwm: sifive: Consistenly " Uwe Kleine-König
2023-07-20 6:48 ` [PATCH 00/10] pwm: Constistenly " Thierry Reding
2023-07-20 7:10 ` Uwe Kleine-König
2023-07-20 15:03 ` Thierry Reding [this message]
2023-07-20 14:41 ` Thierry Reding
2023-09-11 4:31 ` patchwork-bot+chrome-platform
2023-09-11 4:49 ` patchwork-bot+chrome-platform
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZLlMqwAnoPzI8ONt@orome \
--to=thierry.reding@gmail.com \
--cc=alexandre.belloni@bootlin.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=claudiu.beznea@microchip.com \
--cc=elder@kernel.org \
--cc=florian.fainelli@broadcom.com \
--cc=gregkh@linuxfoundation.org \
--cc=greybus-dev@lists.linaro.org \
--cc=groeck@chromium.org \
--cc=heiko@sntech.de \
--cc=johan@kernel.org \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-staging@lists.linux.dev \
--cc=michael@walle.cc \
--cc=nicolas.ferre@microchip.com \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).