linux-riscv.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Paul Walmsley <paul.walmsley@sifive.com>
To: damon <liush.damon@gmail.com>
Cc: sorear2@gmail.com, palmer@sifive.com, anup.patel@wdc.com,
	linux-kernel@vger.kernel.org, rppt@linux.ibm.com,
	aou@eecs.berkeley.edu, linux-riscv@lists.infradead.org
Subject: Re: [PATCH] RISC-V: redefine PTRS_PER_PGD/PTRS_PER_PMD/PTRS_PER_PTE
Date: Fri, 28 Jun 2019 11:52:58 -0700 (PDT)	[thread overview]
Message-ID: <alpine.DEB.2.21.9999.1906281147260.3867@viisi.sifive.com> (raw)
In-Reply-To: <1556093512-5006-1-git-send-email-liush.damon@gmail.com>

On Wed, 24 Apr 2019, damon wrote:

> Use the number of addresses to define the relevant macros.
> 
> Signed-off-by: damon <liush.damon@gmail.com>

This patch looks reasonable to me.  But what's missing from the 
description is the motivation.  Is this a prerequisite for another patch 
that you're planning to post?  Or because you think this is clearer than 
the original?  Or something else?  etc.


- Paul

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

  parent reply	other threads:[~2019-06-28 18:53 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-24  8:11 [PATCH] RISC-V: redefine PTRS_PER_PGD/PTRS_PER_PMD/PTRS_PER_PTE damon
2019-04-24  8:13 ` Anup Patel
2019-06-28 18:52 ` Paul Walmsley [this message]
2019-07-24 12:36   ` sh liu
  -- strict thread matches above, loose matches on Subject: below --
2019-04-24  7:51 damon
2019-04-24  7:59 ` Anup Patel
2019-04-18  0:56 damon
2019-04-18  6:13 ` Anup Patel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.21.9999.1906281147260.3867@viisi.sifive.com \
    --to=paul.walmsley@sifive.com \
    --cc=anup.patel@wdc.com \
    --cc=aou@eecs.berkeley.edu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=liush.damon@gmail.com \
    --cc=palmer@sifive.com \
    --cc=rppt@linux.ibm.com \
    --cc=sorear2@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).