From: Paul Walmsley <paul.walmsley@sifive.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Vincent Chen <vincent.chen@sifive.com>,
linux-riscv@lists.infradead.org, palmer@sifive.com,
linux-kernel@vger.kernel.org, aou@eecs.berkeley.edu
Subject: Re: [PATCH 4/4] riscv: remove the switch statement in do_trap_break()
Date: Mon, 7 Oct 2019 09:30:57 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.21.9999.1910070930270.10936@viisi.sifive.com> (raw)
In-Reply-To: <20191007161050.GA20596@infradead.org>
On Mon, 7 Oct 2019, Christoph Hellwig wrote:
> On Mon, Oct 07, 2019 at 09:08:23AM -0700, Paul Walmsley wrote:
> > force_sig_fault(SIGTRAP, TRAP_BRKPT,
> > (void __user *)(regs->sepc));
>
> No nee for the extra braces, which also means it all fits onto a single
> line.
Good point, will drop the extra parens and remove the braces.
- Paul
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2019-10-07 16:31 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-23 0:45 [PATCH 0/4] riscv: correct the do_trap_break() Vincent Chen
2019-09-23 0:45 ` [PATCH 1/4] riscv: avoid kernel hangs when trapped in BUG() Vincent Chen
2019-09-27 22:25 ` Christoph Hellwig
2019-10-04 18:26 ` Paul Walmsley
2019-09-23 0:45 ` [PATCH 2/4] rsicv: avoid sending a SIGTRAP to a user thread trapped in WARN() Vincent Chen
2019-09-27 22:27 ` Christoph Hellwig
2019-09-27 22:56 ` Christoph Hellwig
2019-09-30 0:22 ` Vincent Chen
2019-10-04 18:26 ` Paul Walmsley
2019-09-23 0:45 ` [PATCH 3/4] riscv: Correct the handling of unexpected ebreak in do_trap_break() Vincent Chen
2019-09-27 22:43 ` Christoph Hellwig
2019-10-04 18:28 ` Paul Walmsley
2019-09-23 0:45 ` [PATCH 4/4] riscv: remove the switch statement " Vincent Chen
2019-09-27 22:47 ` Christoph Hellwig
2019-10-07 16:08 ` Paul Walmsley
2019-10-07 16:10 ` Christoph Hellwig
2019-10-07 16:30 ` Paul Walmsley [this message]
2019-10-08 0:14 ` Vincent Chen
2019-10-08 17:07 ` Paul Walmsley
2019-10-09 22:26 ` Paul Walmsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.9999.1910070930270.10936@viisi.sifive.com \
--to=paul.walmsley@sifive.com \
--cc=aou@eecs.berkeley.edu \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@sifive.com \
--cc=vincent.chen@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).