From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,URIBL_SBL,URIBL_SBL_A, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB06BCA9ECB for ; Thu, 31 Oct 2019 20:49:55 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BB3472087F for ; Thu, 31 Oct 2019 20:49:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="jZtkku/2"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=sifive.com header.i=@sifive.com header.b="VMqvLhOg" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BB3472087F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sifive.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:Message-ID: In-Reply-To:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=QTukInP+7OyOFniR6eeruX1mN4JgpinpCBxEqbGqF9I=; b=jZtkku/2RazB1l 3E7N/J6WOWoJez+NZwH5da1LkmF8WAGwjxWiUYNdt9GPg2UIrJ5izLMac1dQ2fz+7w5HQQbxLlz5q srh2jJxT1TxUFN8r5mN5bb0hF9RWKJXwqhIrKJ3D+HwFuHnU34uS8O3XIBLK3TUt6mTCEVxN7sw9o PKq1+QcMjzWxefBukd6pEyBSqgAojw3HfyavgEtLMe7JF+FaltVij2IpbHAFV+3+2kKBfJqioHk/H RMt1dstX1L0Nb4VOCwbtxiRAuoLC01Gi5BKATjvVFocohwVuKOoGgbUbAH2SXIxv88yDE2xr5J7gB oKgWSCh5nRRM+Yj53ilQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iQHOE-0005PJ-Kl; Thu, 31 Oct 2019 20:49:54 +0000 Received: from mail-io1-xd44.google.com ([2607:f8b0:4864:20::d44]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iQHOA-0005Oe-Ua for linux-riscv@lists.infradead.org; Thu, 31 Oct 2019 20:49:53 +0000 Received: by mail-io1-xd44.google.com with SMTP id u8so8372104iom.5 for ; Thu, 31 Oct 2019 13:49:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=eZuTkF9gdxwYS0tvbddGae71Rmh5FP+LUK5dUhOI+v0=; b=VMqvLhOg8S4c0re6Dw2GImFmJC01f3MugeR8IlfEe6/fiiz97FrlNkmiQkKQoXFWUP xneZvMpjiF23urBUD+OTfkXqHs1CqzR5tZ0rMSpBeOYpjmGxNfil/7RMBgEO9PukcgC1 PnKtRI4StJo3cYG9YcUJXsCMRkp0AxyCo4SEy5N+BK2lRiDnDlkPn0s0MnQ5iWgDHCWZ mauGK2FnUvcuSU3ju2pnszWXoIkX++t7XV78ikoIbirCe25Qqy9YKWzcSFXOVFI9mbgD /jMQ+bbthEOShvS8jtAjHuUL8G6Mp/JFqzcZZgoAJdIR/1QG5lI8BUPlT5z/BNmBu0Ee EmuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=eZuTkF9gdxwYS0tvbddGae71Rmh5FP+LUK5dUhOI+v0=; b=hUk4VYM0EX3iZnPUoBEhHUWcmK92KGv1iz0n7cEAX0LXawnX8tHknDocqm1vGponAJ aQC6QgQaD1EEb1LjbX8CvAdCWOMdfNETLnEiW3YXgkVeFlc+wObx+21I6YbFxlCib/vZ GsgA0tQ6LUa5Dkmt04DbtFLizJ+y++SJCQABSGXwuqddEeLP/LX4AeeoCYlk010nFcbt nS8C27khYn/5p3RAGxP00bA6k9JJpuQkq0xMxJ1DfFGsEH/ZSwsf+ns6Yyq7LpdXAXmX quxoMGILDq0g3dD9b2pXpdJCI8pO5tXOLOb5L66eufNK7YSshinHm+nf6g9CceOOOp4O 1qgg== X-Gm-Message-State: APjAAAWBWCf0EJlbpVVWteQZFBAjG0MGn/CHxvF/jJEDLjmVuYhofucS W3iUwBXQ70dd+EFFuG3QYgf2lA== X-Google-Smtp-Source: APXvYqxCL8rKb+KK9mH6oo8lGPy4DgHa+6+xjM+cFqcKN9RRZY5eVYNe8c9q/wCIIsbXCQOYaKcT/w== X-Received: by 2002:a6b:f415:: with SMTP id i21mr7169015iog.109.1572554989604; Thu, 31 Oct 2019 13:49:49 -0700 (PDT) Received: from localhost ([64.62.168.194]) by smtp.gmail.com with ESMTPSA id e4sm708090ilg.33.2019.10.31.13.49.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 31 Oct 2019 13:49:49 -0700 (PDT) Date: Thu, 31 Oct 2019 13:49:47 -0700 (PDT) From: Paul Walmsley X-X-Sender: paulw@viisi.sifive.com To: Christoph Hellwig Subject: Re: [PATCH 04/12] riscv: cleanup the default power off implementation In-Reply-To: <20191028121043.22934-5-hch@lst.de> Message-ID: References: <20191028121043.22934-1-hch@lst.de> <20191028121043.22934-5-hch@lst.de> User-Agent: Alpine 2.21.9999 (DEB 301 2018-08-15) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191031_134951_048610_FD12B27B X-CRM114-Status: GOOD ( 14.23 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Damien Le Moal , Anup Patel , Palmer Dabbelt , linux-kernel@vger.kernel.org, Atish Patra , linux-riscv@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org On Mon, 28 Oct 2019, Christoph Hellwig wrote: > Move the sbi poweroff to a separate function and file that is only > compiled if CONFIG_SBI is set. Provide a new default fallback > power off that just sits in a wfi loop to save some power. > > Signed-off-by: Christoph Hellwig > Reviewed-by: Anup Patel > Reviewed-by: Atish Patra Thanks, I've split the WFI optimization out into a separate patch (below) and queued it for v5.5-rc1. - Paul From: Christoph Hellwig Date: Wed, 30 Oct 2019 16:11:47 -0700 Subject: [PATCH] riscv: enter WFI in default_power_off() if SBI does not shutdown Provide a new default fallback power off that just sits in a wfi loop to save some power. Signed-off-by: Christoph Hellwig Reviewed-by: Anup Patel Reviewed-by: Atish Patra [paul.walmsley@sifive.com: split the WFI improvement apart from the nommu-related default_power_off() changes; wrote commit summary] Signed-off-by: Paul Walmsley --- arch/riscv/kernel/reset.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/riscv/kernel/reset.c b/arch/riscv/kernel/reset.c index aa56bb135ec4..485be426d9b1 100644 --- a/arch/riscv/kernel/reset.c +++ b/arch/riscv/kernel/reset.c @@ -10,7 +10,8 @@ static void default_power_off(void) { sbi_shutdown(); - while (1); + while (1) + wait_for_interrupt(); } void (*pm_power_off)(void) = default_power_off; -- 2.24.0.rc0 _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv