From: Paul Walmsley <paul.walmsley@sifive.com>
To: David Abdurachmanov <david.abdurachmanov@gmail.com>
Cc: Stefan O'Rear <sorear2@gmail.com>,
Albert Ou <aou@eecs.berkeley.edu>,
David Abdurachmanov <david.abdurachmanov@sifive.com>,
Anup Patel <anup@brainfault.org>,
linux-kernel@vger.kernel.org, Mike Rapoport <rppt@linux.ibm.com>,
Yash Shah <yash.shah@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Greentime Hu <greentime.hu@sifive.com>,
Thomas Gleixner <tglx@linutronix.de>,
Logan Gunthorpe <logang@deltatee.com>,
linux-riscv@lists.infradead.org
Subject: Re: [PATCH v2] define vmemmap before pfn_to_page calls
Date: Fri, 20 Dec 2019 03:08:39 -0800 (PST) [thread overview]
Message-ID: <alpine.DEB.2.21.9999.1912200307400.3767@viisi.sifive.com> (raw)
In-Reply-To: <20191218082814.895851-1-david.abdurachmanov@sifive.com>
On Wed, 18 Dec 2019, David Abdurachmanov wrote:
> pfn_to_page & page_to_pfn depend on vmemmap being available before the calls
> if kernel is configured with CONFIG_SPARSEMEM_VMEMMAP=y. This was caused
> by NOMMU changes which moved vmemmap definition bellow functions definitions
> calling pfn_to_page & page_to_pfn.
>
> Noticed while compiled 5.5-rc2 kernel for Fedora/RISCV.
>
> v2:
> - Add a comment for vmemmap in source
>
> Signed-off-by: David Abdurachmanov <david.abdurachmanov@sifive.com>
> Fixes: 6bd33e1ece52 ("riscv: add nommu support")
> Reviewed-by: Anup Patel <anup@brainfault.org>
This looks like it was due to my error when resolving the merge conflicts,
not Christoph's. Queued for v5.5-rc, thanks David.
- Paul
prev parent reply other threads:[~2019-12-20 11:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-18 8:28 [PATCH v2] define vmemmap before pfn_to_page calls David Abdurachmanov
2019-12-20 11:08 ` Paul Walmsley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.9999.1912200307400.3767@viisi.sifive.com \
--to=paul.walmsley@sifive.com \
--cc=anup@brainfault.org \
--cc=aou@eecs.berkeley.edu \
--cc=david.abdurachmanov@gmail.com \
--cc=david.abdurachmanov@sifive.com \
--cc=greentime.hu@sifive.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=logang@deltatee.com \
--cc=palmer@dabbelt.com \
--cc=rppt@linux.ibm.com \
--cc=sorear2@gmail.com \
--cc=tglx@linutronix.de \
--cc=yash.shah@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).