From: Hal Feng <hal.feng@starfivetech.com>
To: Xingyu Wu <xingyu.wu@starfivetech.com>,
<linux-riscv@lists.infradead.org>, <devicetree@vger.kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Conor Dooley <conor@kernel.org>,
Emil Renner Berthing <kernel@esmil.dk>
Cc: Rob Herring <robh+dt@kernel.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>, <linux-kernel@vger.kernel.org>,
<linux-clk@vger.kernel.org>
Subject: Re: [PATCH v6 02/11] clk: starfive: Add StarFive JH7110 System-Top-Group clock driver
Date: Wed, 31 May 2023 16:56:30 +0800 [thread overview]
Message-ID: <bb490143-e04c-495d-7519-323b653b7351@starfivetech.com> (raw)
In-Reply-To: <20230518101234.143748-3-xingyu.wu@starfivetech.com>
On Thu, 18 May 2023 18:12:25 +0800, Xingyu Wu wrote:
> From: Emil Renner Berthing <emil.renner.berthing@canonical.com>
>
> Add driver for the StarFive JH7110 System-Top-Group clock controller.
>
> Co-developed-by: Xingyu Wu <xingyu.wu@starfivetech.com>
> Signed-off-by: Xingyu Wu <xingyu.wu@starfivetech.com>
> Signed-off-by: Emil Renner Berthing <emil.renner.berthing@canonical.com>
> ---
> drivers/clk/starfive/Kconfig | 11 ++
> drivers/clk/starfive/Makefile | 1 +
> .../clk/starfive/clk-starfive-jh7110-stg.c | 173 ++++++++++++++++++
> 3 files changed, 185 insertions(+)
> create mode 100644 drivers/clk/starfive/clk-starfive-jh7110-stg.c
>
> diff --git a/drivers/clk/starfive/Kconfig b/drivers/clk/starfive/Kconfig
> index 5d2333106f13..d252c03bfb81 100644
> --- a/drivers/clk/starfive/Kconfig
> +++ b/drivers/clk/starfive/Kconfig
> @@ -39,3 +39,14 @@ config CLK_STARFIVE_JH7110_AON
> help
> Say yes here to support the always-on clock controller on the
> StarFive JH7110 SoC.
> +
> +config CLK_STARFIVE_JH7110_STG
> + tristate "StarFive JH7110 System-Top-Group clock support"
> + depends on CLK_STARFIVE_JH7110_SYS
> + select AUXILIARY_BUS
> + select CLK_STARFIVE_JH71X0
> + select RESET_STARFIVE_JH7110
Please drop the above three lines because these three options
are already selected by CLK_STARFIVE_JH7110_SYS. Ditto to for
the isp and vout clock drivers.
With that fixed,
Reviewed-by: Hal Feng <hal.feng@starfivetech.com>
Best regards,
Hal
> + default m if ARCH_STARFIVE
> + help
> + Say yes here to support the System-Top-Group clock controller
> + on the StarFive JH7110 SoC.
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2023-05-31 8:57 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-18 10:12 [PATCH v6 00/11] Add STG/ISP/VOUT clock and reset drivers for StarFive JH7110 Xingyu Wu
2023-05-18 10:12 ` [PATCH v6 01/11] dt-bindings: clock: Add StarFive JH7110 System-Top-Group clock and reset generator Xingyu Wu
2023-05-18 10:12 ` [PATCH v6 02/11] clk: starfive: Add StarFive JH7110 System-Top-Group clock driver Xingyu Wu
2023-05-31 8:56 ` Hal Feng [this message]
2023-05-18 10:12 ` [PATCH v6 03/11] dt-bindings: clock: Add StarFive JH7110 Image-Signal-Process clock and reset generator Xingyu Wu
2023-05-18 10:12 ` [PATCH v6 04/11] clk: starfive: Add StarFive JH7110 Image-Signal-Process clock driver Xingyu Wu
2023-05-18 10:12 ` [PATCH v6 05/11] dt-bindings: clock: Add StarFive JH7110 Video-Output clock and reset generator Xingyu Wu
2023-05-18 10:12 ` [PATCH v6 06/11] clk: starfive: Add StarFive JH7110 Video-Output clock driver Xingyu Wu
2023-05-18 10:12 ` [PATCH v6 07/11] MAINTAINERS: Update maintainer of JH71x0 clock drivers Xingyu Wu
2023-05-18 10:12 ` [PATCH v6 08/11] reset: starfive: jh7110: Add StarFive STG/ISP/VOUT resets support Xingyu Wu
2023-05-31 8:36 ` Hal Feng
2023-05-18 10:12 ` [PATCH v6 09/11] riscv: dts: starfive: jh7110: add pmu controller node Xingyu Wu
2023-05-25 21:42 ` Conor Dooley
2023-05-18 10:12 ` [PATCH v6 10/11] riscv: dts: starfive: jh7110: Add DVP and HDMI TX pixel external clocks Xingyu Wu
2023-05-25 21:44 ` Conor Dooley
2023-05-18 10:12 ` [PATCH v6 11/11] riscv: dts: starfive: jh7110: Add STGCRG/ISPCRG/VOUTCRG nodes Xingyu Wu
2023-07-01 15:45 ` [PATCH v6 00/11] Add STG/ISP/VOUT clock and reset drivers for StarFive JH7110 patchwork-bot+linux-riscv
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bb490143-e04c-495d-7519-323b653b7351@starfivetech.com \
--to=hal.feng@starfivetech.com \
--cc=aou@eecs.berkeley.edu \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@esmil.dk \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mturquette@baylibre.com \
--cc=p.zabel@pengutronix.de \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=xingyu.wu@starfivetech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).