From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Samuel Holland <samuel.holland@sifive.com>,
Thomas Gleixner <tglx@linutronix.de>
Cc: Anup Patel <apatel@ventanamicro.com>,
Chen-Yu Tsai <wens@csie.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Paul Walmsley <paul.walmsley@sifive.com>,
Samuel Holland <samuel@sholland.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org,
linux-sunxi@lists.linux.dev
Subject: Re: [PATCH] clocksource/drivers/timer-sun4i: Partially convert to a platform driver
Date: Wed, 13 Mar 2024 16:29:36 +0100 [thread overview]
Message-ID: <d68fd8a7-8889-472e-86db-b62855eebfba@linaro.org> (raw)
In-Reply-To: <20240312192519.1602493-1-samuel.holland@sifive.com>
On 12/03/2024 20:25, Samuel Holland wrote:
> Commit 8ec99b033147 ("irqchip/sifive-plic: Convert PLIC driver into a
> platform driver") broke the MMIO timer on the Allwinner D1 SoC because
> the IRQ domain is no longer available when timer_probe() is called:
>
> [ 0.000000] irq: no irq domain found for interrupt-controller@10000000 !
> [ 0.000000] Failed to map interrupt for /soc/timer@2050000
> [ 0.000000] Failed to initialize '/soc/timer@2050000': -22
>
> Fix this by wrapping the timer initialization in a platform driver.
> builtin_platform_driver_probe() must be used because the driver uses
> timer_of_init(), which is marked as __init. Only convert the sun8i
> variants of the hardware, because some older SoCs still need the timer
> probed early for sched_clock().
>
> Fixes: 8ec99b033147 ("irqchip/sifive-plic: Convert PLIC driver into a platform driver")
> Signed-off-by: Samuel Holland <samuel.holland@sifive.com>
Why EPROBE_DEFER in thermal-of can not fix the issue?
I mean can't we check if of_irq_get_byname() returns EPROBE_DEFER and
then return this value?
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2024-03-13 15:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-12 19:25 [PATCH] clocksource/drivers/timer-sun4i: Partially convert to a platform driver Samuel Holland
2024-03-13 11:11 ` Daniel Lezcano
2024-03-13 14:43 ` Daniel Lezcano
2024-03-13 16:06 ` Samuel Holland
2024-03-13 15:29 ` Daniel Lezcano [this message]
2024-03-13 16:23 ` Samuel Holland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d68fd8a7-8889-472e-86db-b62855eebfba@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=apatel@ventanamicro.com \
--cc=jernej.skrabec@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=paul.walmsley@sifive.com \
--cc=samuel.holland@sifive.com \
--cc=samuel@sholland.org \
--cc=tglx@linutronix.de \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).