From: Atish Patra <Atish.Patra@wdc.com>
To: "hch@lst.de" <hch@lst.de>,
"paul.walmsley@sifive.com" <paul.walmsley@sifive.com>,
"palmer@sifive.com" <palmer@sifive.com>
Cc: "linux-riscv@lists.infradead.org" <linux-riscv@lists.infradead.org>
Subject: Re: [PATCH 1/6] riscv: refactor the IPI code
Date: Sat, 24 Aug 2019 01:03:18 +0000 [thread overview]
Message-ID: <f1560e8528f3908dccc428e47bd1fc33e2ca2aed.camel@wdc.com> (raw)
In-Reply-To: <20190821145837.3686-2-hch@lst.de>
On Wed, 2019-08-21 at 23:58 +0900, Christoph Hellwig wrote:
> This prepares for adding native non-SBI IPI code.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> arch/riscv/kernel/smp.c | 55 +++++++++++++++++++++++--------------
> ----
> 1 file changed, 31 insertions(+), 24 deletions(-)
>
> diff --git a/arch/riscv/kernel/smp.c b/arch/riscv/kernel/smp.c
> index 5a9834503a2f..8cd730239613 100644
> --- a/arch/riscv/kernel/smp.c
> +++ b/arch/riscv/kernel/smp.c
> @@ -78,13 +78,38 @@ static void ipi_stop(void)
> wait_for_interrupt();
> }
>
> +static void send_ipi_mask(const struct cpumask *mask, enum
> ipi_message_type op)
> +{
> + int cpuid, hartid;
> + struct cpumask hartid_mask;
> +
> + cpumask_clear(&hartid_mask);
> + mb();
> + for_each_cpu(cpuid, mask) {
> + set_bit(op, &ipi_data[cpuid].bits);
> + hartid = cpuid_to_hartid_map(cpuid);
> + cpumask_set_cpu(hartid, &hartid_mask);
> + }
> + mb();
> + sbi_send_ipi(cpumask_bits(&hartid_mask));
> +}
> +
> +static void send_ipi_single(int cpu, enum ipi_message_type op)
> +{
> + send_ipi_mask(cpumask_of(cpu), op);
> +}
> +
> +static inline void clear_ipi(void)
> +{
> + csr_clear(CSR_SIP, SIE_SSIE);
> +}
> +
> void riscv_software_interrupt(void)
> {
> unsigned long *pending_ipis =
> &ipi_data[smp_processor_id()].bits;
> unsigned long *stats = ipi_data[smp_processor_id()].stats;
>
> - /* Clear pending IPI */
> - csr_clear(CSR_SIP, SIE_SSIE);
> + clear_ipi();
>
> while (true) {
> unsigned long ops;
> @@ -118,23 +143,6 @@ void riscv_software_interrupt(void)
> }
> }
>
> -static void
> -send_ipi_message(const struct cpumask *to_whom, enum
> ipi_message_type operation)
> -{
> - int cpuid, hartid;
> - struct cpumask hartid_mask;
> -
> - cpumask_clear(&hartid_mask);
> - mb();
> - for_each_cpu(cpuid, to_whom) {
> - set_bit(operation, &ipi_data[cpuid].bits);
> - hartid = cpuid_to_hartid_map(cpuid);
> - cpumask_set_cpu(hartid, &hartid_mask);
> - }
> - mb();
> - sbi_send_ipi(cpumask_bits(&hartid_mask));
> -}
> -
> static const char * const ipi_names[] = {
> [IPI_RESCHEDULE] = "Rescheduling interrupts",
> [IPI_CALL_FUNC] = "Function call interrupts",
> @@ -156,12 +164,12 @@ void show_ipi_stats(struct seq_file *p, int
> prec)
>
> void arch_send_call_function_ipi_mask(struct cpumask *mask)
> {
> - send_ipi_message(mask, IPI_CALL_FUNC);
> + send_ipi_mask(mask, IPI_CALL_FUNC);
> }
>
> void arch_send_call_function_single_ipi(int cpu)
> {
> - send_ipi_message(cpumask_of(cpu), IPI_CALL_FUNC);
> + send_ipi_single(cpu, IPI_CALL_FUNC);
> }
>
> void smp_send_stop(void)
> @@ -176,7 +184,7 @@ void smp_send_stop(void)
>
> if (system_state <= SYSTEM_RUNNING)
> pr_crit("SMP: stopping secondary CPUs\n");
> - send_ipi_message(&mask, IPI_CPU_STOP);
> + send_ipi_mask(&mask, IPI_CPU_STOP);
> }
>
> /* Wait up to one second for other CPUs to stop */
> @@ -191,6 +199,5 @@ void smp_send_stop(void)
>
> void smp_send_reschedule(int cpu)
> {
> - send_ipi_message(cpumask_of(cpu), IPI_RESCHEDULE);
> + send_ipi_single(cpu, IPI_RESCHEDULE);
> }
> -
Reviewed-by: Atish Patra <atish.patra@wdc.com>
--
Regards,
Atish
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2019-08-24 1:03 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-21 14:58 misc riscv cleanups Christoph Hellwig
2019-08-21 14:58 ` [PATCH 1/6] riscv: refactor the IPI code Christoph Hellwig
2019-08-24 1:03 ` Atish Patra [this message]
2019-09-05 8:44 ` Paul Walmsley
2019-08-21 14:58 ` [PATCH 2/6] riscv: cleanup send_ipi_mask Christoph Hellwig
2019-08-24 0:11 ` Atish Patra
2019-08-26 11:28 ` hch
2019-08-27 18:45 ` Atish Patra
2019-09-05 8:46 ` Paul Walmsley
2019-08-21 14:58 ` [PATCH 3/6] riscv: optimize send_ipi_single Christoph Hellwig
2019-08-24 0:26 ` Atish Patra
2019-08-26 11:29 ` hch
2019-08-27 18:48 ` Atish Patra
2019-09-05 8:48 ` Paul Walmsley
2019-08-21 14:58 ` [PATCH 4/6] riscv: cleanup riscv_cpuid_to_hartid_mask Christoph Hellwig
2019-08-24 0:03 ` Atish Patra
2019-09-05 8:50 ` Paul Walmsley
2019-08-21 14:58 ` [PATCH 5/6] riscv: don't use the rdtime(h) pseudo-instructions Christoph Hellwig
2019-08-24 0:37 ` Atish Patra
2019-08-24 0:43 ` Atish Patra
2019-08-26 11:30 ` hch
2019-08-27 18:50 ` Atish Patra
2019-09-05 8:55 ` Paul Walmsley
2019-08-21 14:58 ` [PATCH 6/6] riscv: move the TLB flush logic out of line Christoph Hellwig
2019-08-24 0:03 ` Atish Patra
2019-09-05 8:58 ` Paul Walmsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f1560e8528f3908dccc428e47bd1fc33e2ca2aed.camel@wdc.com \
--to=atish.patra@wdc.com \
--cc=hch@lst.de \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@sifive.com \
--cc=paul.walmsley@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).