From: Palmer Dabbelt <palmer@sifive.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: atish.patra@wdc.com, linux-riscv@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [GIT PULL] RISC-V Patches for the 5.2 Merge Window, Part 1
Date: Wed, 15 May 2019 18:56:29 -0700 (PDT) [thread overview]
Message-ID: <mhng-3c75df62-0cf8-4e9d-b2f5-0a141fd244e4@palmer-si-x1e> (raw)
In-Reply-To: <CAHk-=wjBRKqBHe5Au=TpDq3B5p=AFKvpaf_7XSU3Mv0MgfGj+A@mail.gmail.com>
On Wed, 15 May 2019 18:49:57 PDT (-0700), Linus Torvalds wrote:
> On Wed, May 15, 2019 at 6:43 PM Palmer Dabbelt <palmer@sifive.com> wrote:
>>
>> Linus: I'm not sure how to tag this PR as a mistake, so I'm going to just send
>> another one. If this gets merged then I'll handle the follow-on.
>
> Just emailing in the same thread ends up with me hopefully seeing the
> "oops, cancel pull request" before I actually pull, so you did the
> right thing.
>
> To make sure, you _could_ obviously also just force-remove the tag you
> asked me to pull, so that if I miss an email any pull attempt of mine
> would just fail.
Ah, OK, I hadn't thought of that one.
> .., and if were to have ended up pulling before you sent the cancel
> email and/or removed the tag, it's obviously all too late, and then
> we'd have to fix things up after the fact, but at least this time it
> got caught in time.
Ya, that's fine. It's just an extra 0-length file that doesn't get built
("file." instead of "file.c"), which explains how it went unnoticed. That
said, it's a bit of an embarassment and I wanted to submit two more patches
anyway so I was going to send another PR. The rebased patches are sitting on
my for-next now, I'll send them up tomorrow unless someone points something
out.
Thanks for the quick reply!
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
prev parent reply other threads:[~2019-05-16 1:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-15 17:39 [GIT PULL] RISC-V Patches for the 5.2 Merge Window, Part 1 Palmer Dabbelt
2019-05-15 19:08 ` Atish Patra
2019-05-16 1:42 ` Palmer Dabbelt
2019-05-16 1:49 ` Linus Torvalds
2019-05-16 1:56 ` Palmer Dabbelt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mhng-3c75df62-0cf8-4e9d-b2f5-0a141fd244e4@palmer-si-x1e \
--to=palmer@sifive.com \
--cc=atish.patra@wdc.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).