From: Palmer Dabbelt <palmer@sifive.com>
To: anup@brainfault.org
Cc: robh@kernel.org, aou@eecs.berkeley.edu,
Greg KH <gregkh@linuxfoundation.org>,
anup@brainfault.org, linux-kernel@vger.kernel.org,
Christoph Hellwig <hch@infradead.org>,
atish.patra@wdc.com, linux-serial@vger.kernel.org,
jslaby@suse.com, linux-riscv@lists.infradead.org
Subject: Re: [PATCH 3/3] RISC-V: Remove EARLY_PRINTK support
Date: Fri, 07 Dec 2018 10:30:32 -0800 (PST) [thread overview]
Message-ID: <mhng-4b39b504-3f5e-4c66-afaa-7929e92a14f7@palmer-si-x1c4> (raw)
In-Reply-To: <20181204135507.3706-4-anup@brainfault.org>
On Tue, 04 Dec 2018 05:55:07 PST (-0800), anup@brainfault.org wrote:
> The EARLY_PRINTK using SBI console calls is not required
> any more because we now have RISC-V SBI support in generic
> earlycon framework.
>
> Signed-off-by: Anup Patel <anup@brainfault.org>
> ---
> arch/riscv/Kconfig.debug | 2 --
> arch/riscv/kernel/setup.c | 28 ----------------------------
> 2 files changed, 30 deletions(-)
>
> diff --git a/arch/riscv/Kconfig.debug b/arch/riscv/Kconfig.debug
> index c5a72f17c469..e69de29bb2d1 100644
> --- a/arch/riscv/Kconfig.debug
> +++ b/arch/riscv/Kconfig.debug
> @@ -1,2 +0,0 @@
> -config EARLY_PRINTK
> - def_bool y
> diff --git a/arch/riscv/kernel/setup.c b/arch/riscv/kernel/setup.c
> index 2c290e6aaa6e..fc8006a042eb 100644
> --- a/arch/riscv/kernel/setup.c
> +++ b/arch/riscv/kernel/setup.c
> @@ -35,31 +35,9 @@
> #include <asm/sections.h>
> #include <asm/pgtable.h>
> #include <asm/smp.h>
> -#include <asm/sbi.h>
> #include <asm/tlbflush.h>
> #include <asm/thread_info.h>
>
> -#ifdef CONFIG_EARLY_PRINTK
> -static void sbi_console_write(struct console *co, const char *buf,
> - unsigned int n)
> -{
> - int i;
> -
> - for (i = 0; i < n; ++i) {
> - if (buf[i] == '\n')
> - sbi_console_putchar('\r');
> - sbi_console_putchar(buf[i]);
> - }
> -}
> -
> -struct console riscv_sbi_early_console_dev __initdata = {
> - .name = "early",
> - .write = sbi_console_write,
> - .flags = CON_PRINTBUFFER | CON_BOOT | CON_ANYTIME,
> - .index = -1
> -};
> -#endif
> -
> #ifdef CONFIG_DUMMY_CONSOLE
> struct screen_info screen_info = {
> .orig_video_lines = 30,
> @@ -219,12 +197,6 @@ static void __init setup_bootmem(void)
>
> void __init setup_arch(char **cmdline_p)
> {
> -#if defined(CONFIG_EARLY_PRINTK)
> - if (likely(early_console == NULL)) {
> - early_console = &riscv_sbi_early_console_dev;
> - register_console(early_console);
> - }
> -#endif
> *cmdline_p = boot_command_line;
>
> parse_early_param();
Reviewed-by: Palmer Dabbelt <palmer@sifive.com>
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2018-12-07 18:30 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-04 13:55 [PATCH 0/3] RISC-V SBI earlycon Anup Patel
2018-12-04 13:55 ` [PATCH 1/3] tty/serial: Add RISC-V SBI earlycon support Anup Patel
2018-12-05 9:58 ` Greg Kroah-Hartman
2018-12-07 18:45 ` Palmer Dabbelt
2018-12-07 18:30 ` Palmer Dabbelt
2019-01-10 14:07 ` [PATCH] tty/serial: emit CR before NL in RISC-V SBL console Andreas Schwab
2019-01-10 15:16 ` Anup Patel
2019-01-10 15:26 ` Andreas Schwab
2019-01-10 16:17 ` Anup Patel
2019-01-10 17:11 ` [PATCH] tty/serial: use uart_console_write in the RISC-V SBL early console Andreas Schwab
2019-01-11 11:13 ` Anup Patel
2019-01-23 23:58 ` Palmer Dabbelt
2019-01-15 13:59 ` Christoph Hellwig
2019-01-10 20:54 ` [PATCH] tty/serial: emit CR before NL in RISC-V SBL console Palmer Dabbelt
2018-12-04 13:55 ` [PATCH 2/3] RISC-V: defconfig: Enable RISC-V SBI earlycon support Anup Patel
2018-12-07 18:30 ` Palmer Dabbelt
2018-12-04 13:55 ` [PATCH 3/3] RISC-V: Remove EARLY_PRINTK support Anup Patel
2018-12-07 18:30 ` Palmer Dabbelt [this message]
2018-12-07 18:30 ` [PATCH 0/3] RISC-V SBI earlycon Palmer Dabbelt
2019-03-25 16:23 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mhng-4b39b504-3f5e-4c66-afaa-7929e92a14f7@palmer-si-x1c4 \
--to=palmer@sifive.com \
--cc=anup@brainfault.org \
--cc=aou@eecs.berkeley.edu \
--cc=atish.patra@wdc.com \
--cc=gregkh@linuxfoundation.org \
--cc=hch@infradead.org \
--cc=jslaby@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-serial@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).