From: Palmer Dabbelt <palmerdabbelt@google.com>
To: Paul Walmsley <paul.walmsley@sifive.com>
Cc: aou@eecs.berkeley.edu, anup@brainfault.org,
Anup Patel <Anup.Patel@wdc.com>,
linux-kernel@vger.kernel.org, Atish Patra <Atish.Patra@wdc.com>,
Alistair Francis <Alistair.Francis@wdc.com>,
linux-riscv@lists.infradead.org, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH v2 4/4] RISC-V: Select Goldfish RTC driver for QEMU virt machine
Date: Thu, 30 Jan 2020 07:41:11 -0800 (PST) [thread overview]
Message-ID: <mhng-c7d78b33-d53f-41c5-955a-604eec4478c6@palmerdabbelt-glaptop1> (raw)
In-Reply-To: <alpine.DEB.2.21.9999.2001221147260.248939@viisi.sifive.com>
On Wed, 22 Jan 2020 19:49:54 GMT (+0000), Paul Walmsley wrote:
> On Tue, 3 Dec 2019, Anup Patel wrote:
>
>> We select Goldfish RTC driver using QEMU virt machine kconfig option
>> to access RTC device on QEMU virt machine.
>>
>> Signed-off-by: Anup Patel <anup.patel@wdc.com>
>> Reviewed-by: Atish Patra <atish.patra@wdc.com>
>> Reviewed-by: Palmer Dabbelt <palmerdabbelt@google.com>
>
> I just grepped for Goldfish through the QEMU git tree, and it didn't come
> up with anything. Per our discussion last year: as a general matter of
> policy, until QEMU merges support for a simulated hardware device into
> their master branch, we shouldn't speculatively enable support for it.
> So, NAK from me on this one until that happens.
Thanks, I thought they were going in through a hw/rtc tree and forgot about
them. I've queued them up for QEMU via the RISC-V tree, there's still some
other patches I'd like to batch up but I'll send them up soon. I don't see any
reason why the Linux patches can't go in via an early-ish RC, so we shoul be
fine.
next prev parent reply other threads:[~2020-01-30 15:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-03 3:49 [PATCH v2 0/4] QEMU Virt Machine Kconfig option Anup Patel
2019-12-03 3:49 ` [PATCH v2 1/4] RISC-V: Add kconfig option for QEMU virt machine Anup Patel
2019-12-03 19:33 ` Alistair Francis
2019-12-03 3:49 ` [PATCH v2 2/4] RISC-V: Enable QEMU virt machine support in defconfigs Anup Patel
2019-12-03 19:34 ` Alistair Francis
2019-12-03 3:49 ` [PATCH v2 3/4] RISC-V: Select SYSCON Reboot and Poweroff for QEMU virt machine Anup Patel
2019-12-03 19:34 ` Alistair Francis
2019-12-03 3:49 ` [PATCH v2 4/4] RISC-V: Select Goldfish RTC driver " Anup Patel
2019-12-03 19:34 ` Alistair Francis
2020-01-22 19:49 ` Paul Walmsley
2020-01-30 15:41 ` Palmer Dabbelt [this message]
2020-02-19 3:22 ` [PATCH v2 0/4] QEMU Virt Machine Kconfig option Anup Patel
2020-03-05 18:49 ` Palmer Dabbelt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mhng-c7d78b33-d53f-41c5-955a-604eec4478c6@palmerdabbelt-glaptop1 \
--to=palmerdabbelt@google.com \
--cc=Alistair.Francis@wdc.com \
--cc=Anup.Patel@wdc.com \
--cc=Atish.Patra@wdc.com \
--cc=anup@brainfault.org \
--cc=aou@eecs.berkeley.edu \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=paul.walmsley@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).