From: Nicolas Pitre <nico@fluxnic.net>
To: Palmer Dabbelt <palmer@sifive.com>
Cc: tesheng@andestech.com, dslin1010@gmail.com,
alankao@andestech.com, rick@andestech.com,
Christoph Hellwig <hch@infradead.org>,
kclin@andestech.com, Paul Walmsley <paul.walmsley@sifive.com>,
linux-riscv@lists.infradead.org, Jim Wilson <jimw@sifive.com>
Subject: Re: About __udivdi3
Date: Tue, 6 Aug 2019 14:37:43 -0400 (EDT) [thread overview]
Message-ID: <nycvar.YSQ.7.76.1908061413360.19480@knanqh.ubzr> (raw)
In-Reply-To: <mhng-206638da-813f-4beb-bb68-ec2ff8fe0730@palmer-si-x1c4>
On Tue, 6 Aug 2019, Palmer Dabbelt wrote:
> Author: Palmer Dabbelt <palmer@sifive.com>
> Date: Tue Aug 6 08:03:59 2019 -0700
>
> RISC-V: Remove udivdi3
>
> This should never have landed in the first place: it was added as part
> of 64-bit divide support for 32-bit systems, but the kernel doesn't
> allow this sort of division. I must have forgotten to remove it.
>
> This patch removes the support. Since this routine only worked on
> 64-bit platforms but was only built on 32-bit platforms, it's
> essentially just nonsense anyway.
>
> Signed-off-by: Palmer Dabbelt <palmer@sifive.com>
Acked-by: Nicolas Pitre <nico@fluxnic.net>
Related: there is still some opportunity for performance gain on rv32 by
providing an assembly version of __arch_xprod_64() if someone is up to
it.
Nicolas
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
prev parent reply other threads:[~2019-08-06 18:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190805055844.GE4292@andestech.com>
2019-08-06 1:37 ` About __udivdi3 Eric Lin
2019-08-06 2:13 ` Paul Walmsley
2019-08-06 2:59 ` Eric Lin
2019-08-06 3:01 ` Jim Wilson
2019-08-06 3:45 ` Nicolas Pitre
2019-08-06 8:31 ` Christoph Hellwig
2019-08-06 15:08 ` Palmer Dabbelt
2019-08-06 17:53 ` Paul Walmsley
2019-08-06 17:59 ` Palmer Dabbelt
2019-08-06 18:37 ` Nicolas Pitre [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.YSQ.7.76.1908061413360.19480@knanqh.ubzr \
--to=nico@fluxnic.net \
--cc=alankao@andestech.com \
--cc=dslin1010@gmail.com \
--cc=hch@infradead.org \
--cc=jimw@sifive.com \
--cc=kclin@andestech.com \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@sifive.com \
--cc=paul.walmsley@sifive.com \
--cc=rick@andestech.com \
--cc=tesheng@andestech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).