From: Yangyu Chen <cyy@cyyself.name>
To: Conor Dooley <conor.dooley@microchip.com>
Cc: Guo Ren <guoren@kernel.org>,
linux-riscv@lists.infradead.org, Conor Dooley <conor@kernel.org>,
Damien Le Moal <dlemoal@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 5/7] riscv: Kconfig.socs: Split ARCH_CANAAN and SOC_CANAAN_K210
Date: Wed, 6 Mar 2024 16:14:33 +0800 [thread overview]
Message-ID: <tencent_91E604E3B4D51DA37045625242A81B07F909@qq.com> (raw)
In-Reply-To: <20240306-scowling-mortify-9b427c80e8ab@wendy>
> On Mar 6, 2024, at 16:01, Conor Dooley <conor.dooley@microchip.com> wrote:
>
> On Wed, Mar 06, 2024 at 07:38:52AM +0800, Guo Ren wrote:
>
>> On Wed, Mar 6, 2024 at 7:04 AM Yangyu Chen <cyy@cyyself.name> wrote:
>>>
>>> Since we have Canaan Kendryte K230 with MMU now. The use of SOC_CANAAN
>>> is no longer only referred to K210. Split them and add _K210 suffix
>>> to the name for old SOC_CANAAN. And allows ARCH_CANAAN to be selected
>>> for other Canaan SoCs.
>>>
>>> Signed-off-by: Yangyu Chen <cyy@cyyself.name>
>>> ---
>>> arch/riscv/Kconfig.socs | 8 +++++---
>>> arch/riscv/Makefile | 2 +-
>>> arch/riscv/configs/nommu_k210_defconfig | 3 ++-
>>> arch/riscv/configs/nommu_k210_sdcard_defconfig | 3 ++-
>>> drivers/clk/Kconfig | 4 ++--
>>> drivers/pinctrl/Kconfig | 4 ++--
>>> drivers/reset/Kconfig | 4 ++--
>>> drivers/soc/Makefile | 2 +-
>>> drivers/soc/canaan/Kconfig | 4 ++--
>>> 9 files changed, 19 insertions(+), 15 deletions(-)
>
>> This patch cross so many subsystems, I am not sure about it. If I were
>> you, I would keep SOC_CANAAN and just add SOC_CANAAN_K230.
>
> Right. That is why I didn't try to rename the symbol, and just left it
> as SOC_CANAAN, but if the relevant people ack it, the chances of a
> significant conflict are low.
>
Maybe I should split this patch into different subsystems for better
review. I think at least drivers/soc/Makefile should changed to use
ARCH_CANAAN. Because we need some SoC drivers for K230 in the future.
And arch/riscv/Makefile should use SOC_CANAAN_K210 instead of
ARCH_CANAAN. Because we should avoid the M-Mode loader build for
other Canaan SoCs except for K210.
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2024-03-06 8:15 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-05 20:01 [PATCH v5 0/7] riscv: add initial support for Canaan Kendryte K230 Yangyu Chen
2024-03-05 20:02 ` [PATCH v5 1/7] dt-bindings: riscv: Add T-HEAD C908 compatible Yangyu Chen
2024-03-05 23:39 ` Guo Ren
2024-03-05 20:02 ` [PATCH v5 2/7] dt-bindings: add Canaan K230 boards compatible strings Yangyu Chen
2024-03-05 20:02 ` [PATCH v5 3/7] dt-bindings: timer: Add Canaan K230 CLINT Yangyu Chen
2024-03-05 23:32 ` Guo Ren
2024-03-05 20:02 ` [PATCH v5 4/7] dt-bindings: interrupt-controller: Add Canaan K230 PLIC Yangyu Chen
2024-03-05 23:39 ` Guo Ren
2024-03-05 20:03 ` [PATCH v5 5/7] riscv: Kconfig.socs: Split ARCH_CANAAN and SOC_CANAAN_K210 Yangyu Chen
2024-03-05 23:38 ` Guo Ren
2024-03-06 8:01 ` Conor Dooley
2024-03-06 8:14 ` Yangyu Chen [this message]
2024-03-20 17:39 ` Conor Dooley
2024-03-20 18:51 ` Conor Dooley
2024-03-21 2:33 ` Yangyu Chen
2024-03-05 20:03 ` [PATCH v5 6/7] riscv: dts: add initial canmv-k230 and k230-evb dts Yangyu Chen
2024-03-05 20:03 ` [PATCH v5 7/7] riscv: config: enable ARCH_CANAAN in defconfig Yangyu Chen
2024-03-05 23:32 ` Guo Ren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tencent_91E604E3B4D51DA37045625242A81B07F909@qq.com \
--to=cyy@cyyself.name \
--cc=aou@eecs.berkeley.edu \
--cc=conor.dooley@microchip.com \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlemoal@kernel.org \
--cc=guoren@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).