From: "Krzysztof Wilczyński" <kw@linux.com>
To: Rob Herring <robh@kernel.org>
Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Heiko Stuebner <heiko@sntech.de>, PCI <linux-pci@vger.kernel.org>,
Shawn Lin <shawn.lin@rock-chips.com>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Michal Simek <michal.simek@xilinx.com>,
"open list:ARM/Rockchip SoC..."
<linux-rockchip@lists.infradead.org>,
Zhou Wang <wangzhou1@hisilicon.com>,
Robert Richter <rrichter@marvell.com>,
Jonathan Chocron <jonnyc@amazon.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Toan Le <toan@os.amperecomputing.com>,
Will Deacon <will@kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v3] PCI: Unify ECAM constants in native PCI Express drivers
Date: Fri, 2 Oct 2020 22:20:17 +0200 [thread overview]
Message-ID: <20201002202017.GA95575@rocinante> (raw)
In-Reply-To: <CAL_JsqJn3uhHgnWeStyADCntJFbG4WpgFW1MAcYR9W3m4o2P=g@mail.gmail.com>
Hi Rob,
[...]
> What about vmd which I mentioned? I also found iproc and brcmstb are
> ECAM (well, same shifts, but indirect addressing).
[...]
I wanted to cover these (and some others I also found) in a separate
patch, especially since some of the drivers don't explicitly claim to
support ECAM - but I will include these changes in the v4.
> > +/
> > + * Enhanced Configuration Access Mechanism (ECAM)
> > + *
> > + * N.B. This is a non-standard platform-specific ECAM bus shift value. For
> > + * standard values defined in the PCI Express Base Specification see
> > + * include/linux/pci-ecam.h.
> > + */
> > +#define XGENE_PCIE_ECAM_BUS_SHIFT 16
>
> Isn't this just CAM? Though perhaps CAM on PCIe is not standard...
>
> For CAM, there's also tegra, ftpci100, mvebu, and versatile. I think
> I'd drop CAM from this patch and do all of those in a separate patch.
Will do.
Bjorn was also not convinced about referring to things as "CAM" since
the specification (the one I quoted in the patch) does not name it as
such, and rather refers to it as Type 1 access of the PCI bus
configuration space.
Krzysztof
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2020-10-02 20:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-01 22:02 [PATCH v3] PCI: Unify ECAM constants in native PCI Express drivers Krzysztof Wilczyński
2020-10-02 15:19 ` Rob Herring
2020-10-02 20:20 ` Krzysztof Wilczyński [this message]
2020-10-02 21:37 ` Bjorn Helgaas
2020-10-02 21:29 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201002202017.GA95575@rocinante \
--to=kw@linux.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=bhelgaas@google.com \
--cc=heiko@sntech.de \
--cc=jonnyc@amazon.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=michal.simek@xilinx.com \
--cc=robh@kernel.org \
--cc=rrichter@marvell.com \
--cc=shawn.lin@rock-chips.com \
--cc=toan@os.amperecomputing.com \
--cc=wangzhou1@hisilicon.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).