From: Tom Rini <trini@konsulko.com>
To: Simon Glass <sjg@chromium.org>
Cc: Heiko Stuebner <heiko@sntech.de>,
U-Boot Mailing List <u-boot@lists.denx.de>,
Markus Reichl <m.reichl@fivetechno.de>,
linux-rockchip@lists.infradead.org,
Jagan Teki <jagan@amarulasolutions.com>,
Suniel Mahesh <sunil@amarulasolutions.com>,
Levin Du <djw@t-chip.com.cn>
Subject: Re: [BUG] [BISECT] rockchip: roc-pc-rk3399: TPL misses dtb
Date: Thu, 18 Feb 2021 08:05:07 -0500 [thread overview]
Message-ID: <20210218130507.GD10169@bill-the-cat> (raw)
In-Reply-To: <CAPnjgZ2Cz1zhbvTBPpOb0jaMWT_J7+okXKUrh8Td5_LfUNSV+g@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 1402 bytes --]
On Wed, Feb 17, 2021 at 09:45:44PM -0700, Simon Glass wrote:
> Hi,
>
> On Mon, 15 Feb 2021 at 08:11, Tom Rini <trini@konsulko.com> wrote:
> >
> > On Mon, Feb 15, 2021 at 03:05:20PM +0100, Markus Reichl wrote:
> >
> > > With recent U-Boot and roc-pc-mezzanine-rk3399_defconfig
> > > and booting from SPI flash I get:
> > >
> > > U-Boot TPL 2021.01-00884-g0a2aaab0b6 (Feb 15 2021 - 14:36:50)
> > > Missing DTB
> > > ### ERROR ### Please RESET the board ###
> > >
> > > Bisecting points to:
> > >
> > > commit 0a2aaab0b678fd1778ff2fc59d0770fc82995532
> > > Author: Simon Glass <sjg@chromium.org>
> > > Date: Wed Jan 13 20:29:49 2021 -0700
> > >
> > > fdtdec: Use CONFIG_IS_ENABLED in board_fdt_blob_setup()
> > > This setting may be different in SPL and TPL. Update the code to check
> > > the correct setting.
> > > Signed-off-by: Simon Glass <sjg@chromium.org>
> > >
> > > lib/fdtdec.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > Reverting this commit fixes booting.
> >
> > Thanks for the report. I'm about to push a revert for this and I'll add
> > a Reported-by from you.
>
> I'm not sure what is going on here, but possibly we need to add
> TPL_SEPARATE_BSS to the board config..
Yes, that's the most likely case, I'm just not sure if we can
progmatically figure out what platforms are missing it.
--
Tom
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
[-- Attachment #2: Type: text/plain, Size: 170 bytes --]
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
prev parent reply other threads:[~2021-02-18 13:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-15 14:05 [BUG] [BISECT] rockchip: roc-pc-rk3399: TPL misses dtb Markus Reichl
2021-02-15 15:11 ` Tom Rini
2021-02-18 4:45 ` Simon Glass
2021-02-18 13:05 ` Tom Rini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210218130507.GD10169@bill-the-cat \
--to=trini@konsulko.com \
--cc=djw@t-chip.com.cn \
--cc=heiko@sntech.de \
--cc=jagan@amarulasolutions.com \
--cc=linux-rockchip@lists.infradead.org \
--cc=m.reichl@fivetechno.de \
--cc=sjg@chromium.org \
--cc=sunil@amarulasolutions.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).