From: Masami Hiramatsu <mhiramat@kernel.org>
To: Tom Zanussi <zanussi@kernel.org>, Steven Rostedt <rostedt@goodmis.org>
Cc: tglx@linutronix.de, mhiramat@kernel.org, namhyung@kernel.org,
bigeasy@linutronix.de, joel@joelfernandes.org,
linux-kernel@vger.kernel.org, linux-rt-users@vger.kernel.org
Subject: [RFC PATCH v2 0/7] tracing: Use common error_log with probe events
Date: Thu, 14 Mar 2019 13:29:49 +0900 [thread overview]
Message-ID: <155253778926.14922.14048967363017104338.stgit@devnote2> (raw)
Hi,
Here is the 2nd version of using common error_log with probe events.
Previous version is here.
http://lkml.kernel.org/r/155248005229.10815.334731901778152247.stgit@devnote2
In this version, I've updated some error messages according to
Steve's comment, adjust some error position, and update testcase
to simplify a bit.
- [4/7]: Update error message according to Steve's comment (Thanks!)
- [6/7]: Update error message, adjust error positions, and add uprobe errors
- [7/7]: Specify error position in command string by "^".
Clear error_log right before writing command.
Add uprobe syntax error checker
Thank you,
---
Masami Hiramatsu (7):
tracing/probe: Check maxactive error cases
tracing/probe: Check event name length correctly
tracing/probe: Check the size of argument name and body
tracing/probe: Check event/group naming rule at parsing
tracing/probe: Verify alloc_trace_*probe() result
tracing: Use tracing error_log with probe events
selftests/ftrace: Add error_log testcase for probe errors
kernel/trace/trace_kprobe.c | 90 ++++--
kernel/trace/trace_probe.c | 282 +++++++++++++++-----
kernel/trace/trace_probe.h | 78 +++++-
kernel/trace/trace_uprobe.c | 52 ++--
.../ftrace/test.d/kprobe/kprobe_syntax_errors.tc | 93 +++++++
.../ftrace/test.d/kprobe/uprobe_syntax_errors.tc | 31 ++
6 files changed, 494 insertions(+), 132 deletions(-)
create mode 100644 tools/testing/selftests/ftrace/test.d/kprobe/kprobe_syntax_errors.tc
create mode 100644 tools/testing/selftests/ftrace/test.d/kprobe/uprobe_syntax_errors.tc
--
Masami Hiramatsu <mhiramat@kernel.org>
next reply other threads:[~2019-03-14 4:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-14 4:29 Masami Hiramatsu [this message]
2019-03-14 4:30 ` [RFC PATCH v2 1/7] tracing/probe: Check maxactive error cases Masami Hiramatsu
2019-03-14 4:30 ` [RFC PATCH v2 2/7] tracing/probe: Check event name length correctly Masami Hiramatsu
2019-03-14 4:30 ` [RFC PATCH v2 3/7] tracing/probe: Check the size of argument name and body Masami Hiramatsu
2019-03-14 4:30 ` [RFC PATCH v2 4/7] tracing/probe: Check event/group naming rule at parsing Masami Hiramatsu
2019-03-14 4:30 ` [RFC PATCH v2 5/7] tracing/probe: Verify alloc_trace_*probe() result Masami Hiramatsu
2019-03-14 4:31 ` [RFC PATCH v2 6/7] tracing: Use tracing error_log with probe events Masami Hiramatsu
2019-03-14 4:31 ` [RFC PATCH v2 7/7] selftests/ftrace: Add error_log testcase for probe errors Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=155253778926.14922.14048967363017104338.stgit@devnote2 \
--to=mhiramat@kernel.org \
--cc=bigeasy@linutronix.de \
--cc=joel@joelfernandes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=namhyung@kernel.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=zanussi@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).