From: Peter Zijlstra <peterz@infradead.org>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: minyard@acm.org, linux-rt-users@vger.kernel.org,
Corey Minyard <cminyard@mvista.com>,
linux-kernel@vger.kernel.org, tglx@linutronix.de,
Steven Rostedt <rostedt@goodmis.org>,
Ingo Molnar <mingo@kernel.org>
Subject: Re: [PATCH RT v2] Fix a lockup in wait_for_completion() and friends
Date: Tue, 14 May 2019 13:35:38 +0200 [thread overview]
Message-ID: <20190514113538.GL2589@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20190514091219.nesriqe7qplk3476@linutronix.de>
On Tue, May 14, 2019 at 11:12:19AM +0200, Sebastian Andrzej Siewior wrote:
> On 2019-05-14 10:43:56 [+0200], Peter Zijlstra wrote:
> > Now.. that will fix it, but I think it is also wrong.
> >
> > The problem being that it violates FIFO, something that might be more
> > important on -RT than elsewhere.
>
> Wouldn't -RT be more about waking the task with the highest priority
> instead the one that waited the longest?
Possibly, but that's a far larger patch. Also, even with that
completions do not avoid inversions and thus don't really make nice RT
primitives anyway.
next prev parent reply other threads:[~2019-05-14 11:35 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-08 20:57 [PATCH v2] Fix a lockup in wait_for_completion() and friends minyard
2019-05-09 16:19 ` [PATCH RT " Sebastian Andrzej Siewior
2019-05-09 17:46 ` Corey Minyard
2019-05-14 8:43 ` Peter Zijlstra
2019-05-14 9:12 ` Sebastian Andrzej Siewior
2019-05-14 11:35 ` Peter Zijlstra [this message]
2019-05-14 15:25 ` Sebastian Andrzej Siewior
2019-05-14 12:13 ` Corey Minyard
2019-05-14 15:36 ` Sebastian Andrzej Siewior
2019-05-15 16:22 ` Corey Minyard
2019-06-26 10:35 ` Peter Zijlstra
2019-05-09 19:33 minyard
2019-05-09 19:51 ` Steven Rostedt
2019-05-10 10:33 ` Sebastian Andrzej Siewior
2019-05-10 12:08 ` Corey Minyard
2019-05-10 12:26 ` Sebastian Andrzej Siewior
2019-06-29 1:49 ` Steven Rostedt
2019-07-01 19:09 ` Corey Minyard
[not found] ` <20190701161840.1a53c9e4@gandalf.local.home>
2019-07-01 20:43 ` Corey Minyard
2019-07-01 21:06 ` Steven Rostedt
2019-07-01 21:13 ` Steven Rostedt
2019-07-01 21:28 ` Steven Rostedt
2019-07-01 21:34 ` Corey Minyard
2019-07-02 7:04 ` Kurt Kanzenbach
2019-07-02 8:35 ` Sebastian Andrzej Siewior
2019-07-02 11:40 ` Corey Minyard
2019-07-02 11:53 ` Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190514113538.GL2589@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=bigeasy@linutronix.de \
--cc=cminyard@mvista.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=minyard@acm.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).