From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Mike Galbraith <efault@gmx.de>
Cc: Fernando Lopez-Lezcano <nando@ccrma.Stanford.EDU>,
Thomas Gleixner <tglx@linutronix.de>,
LKML <linux-kernel@vger.kernel.org>,
linux-rt-users <linux-rt-users@vger.kernel.org>,
Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [ANNOUNCE] v5.4.17-rt9
Date: Wed, 12 Feb 2020 11:20:06 +0100 [thread overview]
Message-ID: <20200212102006.m4psb6rqdps2jw2w@linutronix.de> (raw)
In-Reply-To: <1581055866.25780.7.camel@gmx.de>
On 2020-02-07 07:11:06 [+0100], Mike Galbraith wrote:
> drm/i915/gt: use a LOCAL_IRQ_LOCK in __timeline_mark_lock()
>
> Quoting drm/i915/gt: Mark up the nested engine-pm timeline lock as irqsafe
>
> We use a fake timeline->mutex lock to reassure lockdep that the timeline
> is always locked when emitting requests. However, the use inside
> __engine_park() may be inside hardirq and so lockdep now complains about
> the mixed irq-state of the nested locked. Disable irqs around the
> lockdep tracking to keep it happy.
>
> This lockdep appeasement breaks RT because we take sleeping locks between
> __timeline_mark_lock()/unlock(). Use a LOCAL_IRQ_LOCK instead.
>
> Signed-off-by: Mike Galbraith <efaukt@gmx.de>
Applied, thank you.
Sebastian
prev parent reply other threads:[~2020-02-12 10:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-04 16:58 [ANNOUNCE] v5.4.17-rt9 Sebastian Andrzej Siewior
2020-02-06 23:59 ` Fernando Lopez-Lezcano
2020-02-07 6:11 ` Mike Galbraith
2020-02-07 6:13 ` Fernando Lopez-Lezcano
2020-02-07 6:56 ` Mike Galbraith
2020-06-20 10:09 ` v5.4.17-rt10 does not boot on intel ycollette.nospam
2020-06-20 12:35 ` ycollette.nospam
2020-06-25 16:55 ` v5.6.17 (was v5.4.17-rt10) " Fernando Lopez-Lezcano
2020-02-12 10:20 ` Sebastian Andrzej Siewior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200212102006.m4psb6rqdps2jw2w@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=efault@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=nando@ccrma.Stanford.EDU \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).