linux-rt-users.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: John Ogness <john.ogness@linutronix.de>
Cc: Petr Mladek <pmladek@suse.com>,
	Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
	linux-kernel@vger.kernel.org, linux-rt-users@vger.kernel.org
Subject: Re: [PATCH RT] printk: console must not schedule for drivers
Date: Wed, 15 Apr 2020 18:34:16 +0200	[thread overview]
Message-ID: <20200415163416.r3fce3g5kokm4bub@linutronix.de> (raw)
In-Reply-To: <20200406212217.2323-1-john.ogness@linutronix.de>

On 2020-04-06 23:22:17 [+0200], John Ogness wrote:
> Even though the printk kthread is always preemptible, it is still not
> allowed to call cond_resched() from within console drivers. The
> task may become non-preemptible in the console driver call chain. For
> example, vt_console_print() takes a spinlock and then can call into
> fbcon_redraw(), which can conditionally invoke cond_resched():
> 
> BUG: sleeping function called from invalid context at kernel/printk/printk.c:2322
> in_atomic(): 1, irqs_disabled(): 0, non_block: 0, pid: 177, name: printk
> CPU: 0 PID: 177 Comm: printk Not tainted 5.6.2-00011-ga536059557f1d9 #1
> Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.12.0-1 04/01/2014
> Call Trace:
>  dump_stack+0x66/0x8b
>  ___might_sleep+0x102/0x120
>  console_conditional_schedule+0x24/0x30
>  fbcon_redraw+0x96/0x1c0
>  ? fbcon_cursor+0x100/0x190
>  fbcon_scroll+0x556/0xd70
>  con_scroll+0x147/0x1e0
>  lf+0x9e/0xb0
>  vt_console_print+0x253/0x3d0
>  printk_kthread_func+0x1d5/0x3b0
> 
> Disable cond_resched() for the call into the console drivers.

Interesting. So you get a report and I don't?

I have also patch related questions :)
- So before the re-rewrite, console_unlock() set this 0 before invoking
  the console drivers so it was always 0. I assume it was called with
  disabled interrupts.

- Is there a scenario in fbcon where this function is invoked and
  console_may_schedule is not 0?

Sebastian

  reply	other threads:[~2020-04-15 16:34 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-06 21:22 [PATCH RT] printk: console must not schedule for drivers John Ogness
2020-04-15 16:34 ` Sebastian Andrzej Siewior [this message]
2020-04-16  8:13   ` John Ogness
2020-04-16 11:04     ` Sebastian Andrzej Siewior
2020-04-16 13:20     ` John Ogness

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200415163416.r3fce3g5kokm4bub@linutronix.de \
    --to=bigeasy@linutronix.de \
    --cc=john.ogness@linutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rt-users@vger.kernel.org \
    --cc=pmladek@suse.com \
    --cc=sergey.senozhatsky@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).