From: Peter Xu <peterx@redhat.com>
To: linux-rt-users@vger.kernel.org
Cc: John Kacur <jkacur@redhat.com>,
peterx@redhat.com, Clark Williams <williams@redhat.com>,
Daniel Wagner <dwagner@suse.de>
Subject: [PATCH] rt-tests: Drop use_current_cpuset() check
Date: Mon, 15 Mar 2021 15:37:07 -0400 [thread overview]
Message-ID: <20210315193707.359702-1-peterx@redhat.com> (raw)
CPU list should allow to be any list rather than only the cores that are
allowed to schedule for the current process.
Before this patch, cyclictest will fail with below condition:
$ taskset -pc $$
pid 2316's current affinity list: 0,2,4,6,8
$ sudo cyclictest -m -N -p 1 -a 1,3,5,7 -t 4
WARN: Couldn't setaffinity in main thread: Invalid argument
After this patch, it'll be allowed to run.
Cc: Daniel Wagner <dwagner@suse.de>
Signed-off-by: Peter Xu <peterx@redhat.com>
---
src/lib/rt-numa.c | 27 ---------------------------
1 file changed, 27 deletions(-)
diff --git a/src/lib/rt-numa.c b/src/lib/rt-numa.c
index babcc63..f581020 100644
--- a/src/lib/rt-numa.c
+++ b/src/lib/rt-numa.c
@@ -93,32 +93,6 @@ int cpu_for_thread_ua(int thread_num, int max_cpus)
return 0;
}
-/*
- * After this function is called, affinity_mask is the intersection of
- * the user supplied affinity mask and the affinity mask from the run
- * time environment
- */
-static void use_current_cpuset(int max_cpus, struct bitmask *cpumask)
-{
- struct bitmask *curmask;
- int i;
-
- curmask = numa_allocate_cpumask();
- numa_sched_getaffinity(getpid(), curmask);
-
- /*
- * Clear bits that are not set in both the cpuset from the
- * environment, and in the user specified affinity.
- */
- for (i = 0; i < max_cpus; i++) {
- if ((!numa_bitmask_isbitset(cpumask, i)) ||
- (!numa_bitmask_isbitset(curmask, i)))
- numa_bitmask_clearbit(cpumask, i);
- }
-
- numa_bitmask_free(curmask);
-}
-
int parse_cpumask(char *str, int max_cpus, struct bitmask **cpumask)
{
struct bitmask *mask;
@@ -133,7 +107,6 @@ int parse_cpumask(char *str, int max_cpus, struct bitmask **cpumask)
return 0;
}
- use_current_cpuset(max_cpus, mask);
*cpumask = mask;
return 0;
--
2.26.2
next reply other threads:[~2021-03-15 19:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-15 19:37 Peter Xu [this message]
2021-03-16 8:18 ` [PATCH] rt-tests: Drop use_current_cpuset() check Daniel Wagner
2021-03-16 20:07 ` Peter Xu
2021-03-17 7:49 ` Daniel Wagner
2021-03-17 12:51 ` Peter Xu
2021-03-17 15:08 ` John Kacur
2021-03-17 15:21 ` Peter Xu
2021-03-17 15:47 ` John Kacur
2021-03-17 17:20 ` Daniel Wagner
2021-03-17 16:40 ` Ahmed S. Darwish
2021-03-17 17:15 ` Daniel Wagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210315193707.359702-1-peterx@redhat.com \
--to=peterx@redhat.com \
--cc=dwagner@suse.de \
--cc=jkacur@redhat.com \
--cc=linux-rt-users@vger.kernel.org \
--cc=williams@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).