From: Mel Gorman <mgorman@techsingularity.net>
To: Linux-MM <linux-mm@kvack.org>,
Linux-RT-Users <linux-rt-users@vger.kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Chuck Lever <chuck.lever@oracle.com>,
Jesper Dangaard Brouer <brouer@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>, Michal Hocko <mhocko@kernel.org>,
Vlastimil Babka <vbabka@suse.cz>,
Mel Gorman <mgorman@techsingularity.net>
Subject: [PATCH 09/10] mm/page_alloc: Update PGFREE outside the zone lock in __free_pages_ok
Date: Mon, 19 Apr 2021 15:13:40 +0100 [thread overview]
Message-ID: <20210419141341.26047-10-mgorman@techsingularity.net> (raw)
In-Reply-To: <20210419141341.26047-1-mgorman@techsingularity.net>
VM events do not need explicit protection by disabling IRQs so
update the counter with IRQs enabled in __free_pages_ok.
Signed-off-by: Mel Gorman <mgorman@techsingularity.net>
Acked-by: Vlastimil Babka <vbabka@suse.cz>
---
mm/page_alloc.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index a9c1282d9c7b..44a5eb067b38 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -1557,13 +1557,14 @@ static void __free_pages_ok(struct page *page, unsigned int order,
migratetype = get_pfnblock_migratetype(page, pfn);
spin_lock_irqsave(&zone->lock, flags);
- __count_vm_events(PGFREE, 1 << order);
if (unlikely(has_isolate_pageblock(zone) ||
is_migrate_isolate(migratetype))) {
migratetype = get_pfnblock_migratetype(page, pfn);
}
__free_one_page(page, pfn, zone, order, migratetype, fpi_flags);
spin_unlock_irqrestore(&zone->lock, flags);
+
+ __count_vm_events(PGFREE, 1 << order);
}
void __free_pages_core(struct page *page, unsigned int order)
--
2.26.2
next prev parent reply other threads:[~2021-04-19 14:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-19 14:13 [PATCH 00/10 v4] Use local_lock for pcp protection and reduce stat overhead Mel Gorman
2021-04-19 14:13 ` [PATCH 01/10] mm/page_alloc: Split per cpu page lists and zone stats Mel Gorman
2021-04-19 14:13 ` [PATCH 02/10] mm/page_alloc: Convert per-cpu list protection to local_lock Mel Gorman
2021-04-19 14:13 ` [PATCH 03/10] mm/vmstat: Convert NUMA statistics to basic NUMA counters Mel Gorman
2021-04-19 14:13 ` [PATCH 04/10] mm/vmstat: Inline NUMA event counter updates Mel Gorman
2021-04-19 14:13 ` [PATCH 05/10] mm/page_alloc: Batch the accounting updates in the bulk allocator Mel Gorman
2021-04-19 14:13 ` [PATCH 06/10] mm/page_alloc: Reduce duration that IRQs are disabled for VM counters Mel Gorman
2021-04-19 14:13 ` [PATCH 07/10] mm/page_alloc: Explicitly acquire the zone lock in __free_pages_ok Mel Gorman
2021-04-19 14:13 ` [PATCH 08/10] mm/page_alloc: Avoid conflating IRQs disabled with zone->lock Mel Gorman
2021-04-19 14:13 ` Mel Gorman [this message]
2021-04-19 14:13 ` [PATCH 10/10] mm/page_alloc: Embed per_cpu_pages locking within the per-cpu structure Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210419141341.26047-10-mgorman@techsingularity.net \
--to=mgorman@techsingularity.net \
--cc=brouer@redhat.com \
--cc=chuck.lever@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=mhocko@kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).