From: John Kacur <jkacur@redhat.com>
To: Daniel Wagner <wagi@monom.org>
Cc: Christian Eggers <ceggers@arri.de>,
RT <linux-rt-users@vger.kernel.org>,
Daniel Wagner <dwagner@suse.de>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Kurt Kanzenbach <kurt.kanzenbach@linutronix.de>,
Clark Williams <williams@redhat.com>
Subject: Re: [PATCH 0/3] Revert always use libnuma patches
Date: Mon, 22 Feb 2021 17:10:38 -0500 (EST) [thread overview]
Message-ID: <2d2a7ea-ecb7-555e-ae80-83e791de7cad@redhat.com> (raw)
In-Reply-To: <20210222082503.b2u3s2ftv3os474f@beryllium.lan>
On Mon, 22 Feb 2021, Daniel Wagner wrote:
> On Fri, Feb 19, 2021 at 04:30:39PM -0500, John Kacur wrote:
> > I think I see the problem, the patch
> > rt-numa: Move thread placement code to rt-numa library
> >
> > added the fatal if numa_failed.
>
> Sorry about the mess, I thought we can relay on libnuma. The concept to
> depend on compile time on a library and not during runtime escaped my
> attention.
No problem, I should have caught this myself in code review.
I had honestly forgotten that when we made numa a compile time requirement
that we made it so that it was not a runtime requirement, even though I
wrote most of the code to achieve that.
>
> > Thanks for testing. I'll send a patch to put it back the old way.
>
> Thanks John!
>
prev parent reply other threads:[~2021-02-22 22:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-19 18:47 [PATCH 0/3] Revert always use libnuma patches John Kacur
2021-02-19 18:47 ` [PATCH 1/3] Revert "cyclictest: Use affinity_mask for steering thread placement" John Kacur
2021-02-19 18:48 ` [PATCH 2/3] Revert "cyclictest: Always use libnuma" John Kacur
2021-02-19 18:48 ` [PATCH 3/3] Revert "signaltest: " John Kacur
2021-02-19 20:27 ` [PATCH 0/3] Revert always use libnuma patches Christian Eggers
2021-02-19 21:30 ` John Kacur
2021-02-22 8:25 ` Daniel Wagner
2021-02-22 22:10 ` John Kacur [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2d2a7ea-ecb7-555e-ae80-83e791de7cad@redhat.com \
--to=jkacur@redhat.com \
--cc=bigeasy@linutronix.de \
--cc=ceggers@arri.de \
--cc=dwagner@suse.de \
--cc=kurt.kanzenbach@linutronix.de \
--cc=linux-rt-users@vger.kernel.org \
--cc=wagi@monom.org \
--cc=williams@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).