From: Tom Zanussi <zanussi@kernel.org>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: linux-rt-users <linux-rt-users@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [4.19 stable-rt PATCH] tasklet: Fix UP case for tasklet CHAINED state
Date: Tue, 09 Jun 2020 11:59:11 -0500 [thread overview]
Message-ID: <5ed2c074f367c2939d0cce494b85f9f5d74d4234.camel@kernel.org> (raw)
In-Reply-To: <20200609163832.vicpmza6qgxalhmg@linutronix.de>
Hi Sebastian,
On Tue, 2020-06-09 at 18:38 +0200, Sebastian Andrzej Siewior wrote:
> On 2020-06-09 11:21:44 [-0500], Tom Zanussi wrote:
> > index 73dae64bfc9c..4f37a6173ab9 100644
> > --- a/kernel/softirq.c
> > +++ b/kernel/softirq.c
> > @@ -947,10 +947,12 @@ static void __tasklet_schedule_common(struct
> > tasklet_struct *t,
> > * is locked before adding it to the list.
> > */
> > if (test_bit(TASKLET_STATE_SCHED, &t->state)) {
> > +#if defined(CONFIG_SMP)
> > if (test_and_set_bit(TASKLET_STATE_CHAINED, &t->state))
> > {
> > tasklet_unlock(t);
> > return;
> > }
> > +#endif
> > t->next = NULL;
> > *head->tail = t;
> > head->tail = &(t->next);
> > @@ -1044,7 +1046,11 @@ static void tasklet_action_common(struct
> > softirq_action *a,
> > again:
> > t->func(t->data);
> >
> > +#if !defined(CONFIG_SMP)
> > + while (!tasklet_tryunlock(t)) {
> > +#else
> > while (cmpxchg(&t->state, TASKLET_STATEF_RC, 0) !=
> > TASKLET_STATEF_RC) {
> > +#endif
>
> This is still needed for RT && !SMP
>
Yes, you're right - I'll change this and repost after testing all
cases.
Thanks,
Tom
> > /*
> > * If it got disabled meanwhile, bail out:
> > */
>
> Sebastian
prev parent reply other threads:[~2020-06-09 16:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-09 16:21 [4.19 stable-rt PATCH] tasklet: Fix UP case for tasklet CHAINED state Tom Zanussi
2020-06-09 16:38 ` Sebastian Andrzej Siewior
2020-06-09 16:59 ` Tom Zanussi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5ed2c074f367c2939d0cce494b85f9f5d74d4234.camel@kernel.org \
--to=zanussi@kernel.org \
--cc=bigeasy@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).