Re: firewire-ohci fails to initialize Texas Instruments XIO2213A/B/XIO2221 based controller on realtime kernels [5.4.91-rt50, 5.10.8-rt24]

From: David Runge <dave@sleepmap.de>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	Kristian Hoegsberg <krh@bitplanet.net>,
	linux1394-devel@lists.sourceforge.net,
	linux-rt-users@vger.kernel.org,
	"Ahmed S. Darwish" <a.darwish@linutronix.de>
Subject: Re: firewire-ohci fails to initialize Texas Instruments XIO2213A/B/XIO2221 based controller on realtime kernels [5.4.91-rt50, 5.10.8-rt24]
Date: Wed, 8 Sep 2021 19:30:14 +0200	[thread overview]
Message-ID: <YTjzKftQmFtPLYUR@hmbx> (raw)
In-Reply-To: <YTgdLkTs7wEmj8fh@workstation>

[-- Attachment #1: Type: text/plain, Size: 1952 bytes --]

Hi Takashi,

thanks for the prompt and detailed response!

Unfortunately I lack the knowledge about the driver and its inner
workings to be able to provide a patch for this issue myself.
If anyone reading this who is able to suggest a fix, I'd be happy to
test it!

On 2021-09-08 11:17:18 (+0900), Takashi Sakamoto wrote:
> I guess we have issue in the softIRQ context or timer wheel context
> instead of hwIRQ context, if the OHCI 1394 controller you use has
> no quirk (I suggest you to give information about the controller).
> 
> I'd like you to check it. The firewire-ohci module has 'debug' parameter.
> 
> ``
> $ modinfo firewire-ohci
> ...
> parm:           debug:Verbose logging (default = 0, AT/AR events = 1, self-IDs = 2, IRQs = 4, busReset events = 8, or a combination, or all = -1) (int)
> ``

I am using '-1' (all) in the 2nd link in my previous mail. It appears to
not show a different output in the kernel logs from when I set it to '5'
though. There seems to be something wrong...
I'm adding the options in a .conf file below /etc/modprobe.d/, e.g.:

```
options firewire-ohci debug=5
```

The only output I get from that is:

```
firewire_ohci 0000:05:00.0: enabling device (0000 -> 0002)
firewire_ohci 0000:05:00.0: added OHCI v1.10 device as card 0, 8 IR + 8 IT contexts, quirks 0x2
firewire_core 0000:05:00.0: created device fw0: GUID 7856341278563412, S800
firewire_ohci 0000:05:00.0: isochronous cycle inconsistent
firewire_core 0000:05:00.0: created device fw1: GUID 000a3500ada83262, S400
firewire_core 0000:05:00.0: phy config: new root=ffc0, gap_count=5
```

This is with starting with the audio interface connected and on. I have
to switch it off and on again to get recognized, but then the driver
crashes (full kernel log [1])

[1] https://pkgbuild.com/~dvzrv/bugs/2021/09/linux-5.14.1.19.realtime1-firewire-ohci-debug-kernel.log

Best,
David

-- 
https://sleepmap.de

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]