From: John Kacur <jkacur@redhat.com>
To: Sultan Alsawaf <sultan@kerneltoast.com>
Cc: linux-kernel@vger.kernel.org, linux-rt-users@vger.kernel.org,
sebastian@breakpoint.cc, tglx@linutronix.de, rostedt@goodmis.org
Subject: Re: [PATCH] rt-tests: backfire: Don't include asm/uaccess.h directly
Date: Mon, 16 Sep 2019 23:57:32 +0200 (CEST) [thread overview]
Message-ID: <alpine.LFD.2.21.1909162356500.10273@planxty> (raw)
In-Reply-To: <20190903191321.6762-1-sultan@kerneltoast.com>
On Tue, 3 Sep 2019, Sultan Alsawaf wrote:
> From: Sultan Alsawaf <sultan@kerneltoast.com>
>
> Architecture-specific uaccess.h headers can have dependencies on
> linux/uaccess.h (i.e., VERIFY_WRITE), so it cannot be included directly.
> Since linux/uaccess.h includes asm/uaccess.h, just do that instead.
>
> This fixes compile errors with certain kernels and architectures.
>
> Signed-off-by: Sultan Alsawaf <sultan@kerneltoast.com>
> ---
> src/backfire/backfire.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/backfire/backfire.c b/src/backfire/backfire.c
> index aaf9c4a..a8ac9f5 100644
> --- a/src/backfire/backfire.c
> +++ b/src/backfire/backfire.c
> @@ -30,8 +30,8 @@
> #include <linux/miscdevice.h>
> #include <linux/proc_fs.h>
> #include <linux/spinlock.h>
> +#include <linux/uaccess.h>
>
> -#include <asm/uaccess.h>
> #include <asm/system.h>
>
> #define BACKFIRE_MINOR MISC_DYNAMIC_MINOR
> --
> 2.23.0
>
>
Signed-off-by: John Kacur <jkacur@redhat.com>
But please in the future
1. Don't cc lkml on this
2. Include the maintainers in your patch
Thanks
next prev parent reply other threads:[~2019-09-16 21:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-03 19:13 [PATCH] rt-tests: backfire: Don't include asm/uaccess.h directly Sultan Alsawaf
2019-09-16 21:57 ` John Kacur [this message]
2019-09-17 7:15 ` Sultan Alsawaf
2019-09-17 10:28 ` Kurt Kanzenbach
2019-09-17 14:14 ` John Kacur
2019-09-17 10:24 ` Sebastian Andrzej Siewior
2019-09-17 14:12 ` John Kacur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.21.1909162356500.10273@planxty \
--to=jkacur@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=sebastian@breakpoint.cc \
--cc=sultan@kerneltoast.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).