linux-rt-users.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: John Kacur <jkacur@redhat.com>
To: Kurt Kanzenbach <kurt.kanzenbach@linutronix.de>
Cc: Clark Williams <williams@redhat.com>,
	RT <linux-rt-users@vger.kernel.org>
Subject: Re: [PATCH 2/9] rt-tests: cyclicdeadline: Add a simple manpage for cyclicdeadline
Date: Mon, 27 Jan 2020 12:40:15 -0500 (EST)	[thread overview]
Message-ID: <alpine.LFD.2.21.2001271213260.7301@planxty> (raw)
In-Reply-To: <877e1dxjo4.fsf@kurt>



On Mon, 27 Jan 2020, Kurt Kanzenbach wrote:

> Hi John,
> 
> On Thu Jan 23 2020, John Kacur wrote:
> > - Add a simple manpage for cyclicdeadline
> > - Install it from the Makefile
> >
> > Signed-off-by: John Kacur <jkacur@redhat.com>
> > ---
> >  Makefile                            |  1 +
> >  src/sched_deadline/cyclicdeadline.8 | 53 +++++++++++++++++++++++++++++
> >  2 files changed, 54 insertions(+)
> >  create mode 100644 src/sched_deadline/cyclicdeadline.8
> >
> > diff --git a/Makefile b/Makefile
> > index 552b3fe885cc..e2142ba3f4e9 100644
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -193,6 +193,7 @@ install: all install_hwlatdetect
> >  	gzip -c src/queuelat/queuelat.8 >"$(DESTDIR)$(mandir)/man8/queuelat.8.gz"
> >  	gzip -c src/sched_deadline/deadline_test.8 >"$(DESTDIR)$(mandir)/man8/deadline_test.8.gz"
> >  	gzip -c src/ssdd/ssdd.8 >"$(DESTDIR)$(mandir)/man8/ssdd.8.gz"
> > +	gzip -c src/sched_deadline/cyclicdeadline.8 >"$(DESTDIR)$(mandir)/man8/cyclicdeadline.8.gz"
> 
> I'm just wondering about this. Why are the man pages compressed in the
> Makefile? Actually most package management systems compress the man
> pages themselves. Users may want to use bz2 or something else.
> 
> In fact, I have a patch on top of rt-tests v1.6 in Gentoo which removes
> the compression, because portage complains about it.
> 
> Thanks,
> Kurt
> 

I think it's because man pages are generally installed as .gz files on 
most distros. Although the Makefile is designed to work well with package 
management systems, it should also work correctly stand alone.

If you want to submit a patch that would optionally use a different kind 
of compression or otherwise handle things without breaking the current 
defaults, I would likely accept it.

John

  reply	other threads:[~2020-01-27 17:40 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-23 20:50 [PATCH 0/9] rt-tests: Miscellaneous fixes John Kacur
2020-01-23 20:50 ` [PATCH 1/9] rt-tests: queuelat: Assume queuelat is in the path John Kacur
2020-01-23 20:50 ` [PATCH 2/9] rt-tests: cyclicdeadline: Add a simple manpage for cyclicdeadline John Kacur
2020-01-27 10:44   ` Kurt Kanzenbach
2020-01-27 17:40     ` John Kacur [this message]
2020-01-28  7:13       ` Kurt Kanzenbach
2020-01-23 20:50 ` [PATCH 3/9] rt-tests: pi_stress: Add short options to usage message John Kacur
2020-01-23 20:50 ` [PATCH 4/9] rt-tests: pi_stress: Sync man page with help John Kacur
2020-01-23 20:50 ` [PATCH 5/9] rt-tests: queuelat: get_cpuinfo_mhz.sh highest value John Kacur
2020-01-23 20:50 ` [PATCH 6/9] rt-tests: determine_maximum_mpps.sh: Fix quoting and other shell issue John Kacur
2020-01-23 20:50 ` [PATCH 7/9] rt-tests: ptsematest: Update man page and add -h option John Kacur
2020-01-23 20:50 ` [PATCH 8/9] rt-tests: queuelat: Fixes to man page and display_help John Kacur
2020-01-23 20:50 ` [PATCH 9/9] rt-tests: svsematest: Display help with an error message for -h John Kacur
2020-01-27 21:44 ` [PATCH 0/9] rt-tests: Miscellaneous fixes Clark Williams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.21.2001271213260.7301@planxty \
    --to=jkacur@redhat.com \
    --cc=kurt.kanzenbach@linutronix.de \
    --cc=linux-rt-users@vger.kernel.org \
    --cc=williams@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).