From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Jeremy Gebben <jgebben@sweptlaser.com>,
Alessandro Zummo <a.zummo@towertech.it>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
linux-rtc@vger.kernel.org, linux-watchdog@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] rtc: abx80x: add basic watchdog support
Date: Tue, 11 Sep 2018 09:39:22 +0200 [thread overview]
Message-ID: <20180911073922.GG2494@piout.net> (raw)
In-Reply-To: <20180910232019.GA8439@roeck-us.net>
On 10/09/2018 16:20:19-0700, Guenter Roeck wrote:
> > +static int abx80x_wdog_set_timeout(struct watchdog_device *wdog,
> > + unsigned int new_timeout)
>
> I'll leave multi-line alignment issues to the driver maintainer.
>
Indeed, I'd like those to be aligned on the parenthesis.
Thank you for your review.
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2018-09-11 12:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-10 21:36 [PATCH v2 0/2] rtc: abx80x: add basic watchdog support Jeremy Gebben
2018-09-10 21:36 ` [PATCH 1/2] rtc: abx80x: use a 'priv' struct for client data Jeremy Gebben
2018-09-10 21:36 ` [PATCH 2/2] rtc: abx80x: add basic watchdog support Jeremy Gebben
2018-09-10 23:20 ` Guenter Roeck
2018-09-11 7:39 ` Alexandre Belloni [this message]
2018-09-11 17:28 [PATCH v3 0/2] " Jeremy Gebben
2018-09-11 17:28 ` [PATCH 2/2] " Jeremy Gebben
2018-09-11 21:49 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180911073922.GG2494@piout.net \
--to=alexandre.belloni@bootlin.com \
--cc=a.zummo@towertech.it \
--cc=jgebben@sweptlaser.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).