From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: "Howey, Dylan" <Dylan.Howey@tennantco.com>
Cc: "a.zummo@towertech.it" <a.zummo@towertech.it>,
"linux-rtc@vger.kernel.org" <linux-rtc@vger.kernel.org>
Subject: Re: [PATCH 1/2] Port rtc-pcf2123 to regmap
Date: Tue, 30 Apr 2019 11:22:56 +0200 [thread overview]
Message-ID: <20190430092256.GC11339@piout.net> (raw)
In-Reply-To: <20190429150913.GA15052@tennantco.com>
On 29/04/2019 15:09:18+0000, Howey, Dylan wrote:
> Thanks for the quick response. This is actually the first time I've
> submitted changes to this project.
>
> The 04/27/2019 15:00, Alexandre Belloni wrote:
> > > -static int pcf2123_write_reg(struct device *dev, u8 reg, u8 val)
> > > -{
> > > - u8 txbuf[2];
> > > +static const struct regmap_range pcf2123_ranges[] = {
> > > + {
> > > + .range_min = PCF2123_REG_CTRL1,
> > > + .range_max = PCF2123_REG_CTDWN_TMR,
> > > + },
> > > +};
> > >
> > > - txbuf[0] = reg;
> > > - txbuf[1] = val;
> > > - return pcf2123_write(dev, txbuf, sizeof(txbuf));
> > > -}
> > > +static const struct regmap_access_table pcf2123_access_table = {
> > > + .yes_ranges = pcf2123_ranges,
> > > + .n_yes_ranges = ARRAY_SIZE(pcf2123_ranges),
> > > +};
> >
> > This covers all the registers, I don't think this is necessary.
> >
> This would cover the same registers that are exposed by the sysfs
> interface. I can take out the timer registers since this driver does not
> support the periodic timer.
>
What I meant is that you probably don't need the access table as the
whole range is already between 0 and max_register so there is no need to
double check.
> I agree with the rest of your feedback. When I send a V2 patch should I
> respond to this thread?
>
This should be sent as a separate thred.
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2019-04-30 9:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-26 19:37 [PATCH 1/2] Port rtc-pcf2123 to regmap Howey, Dylan
2019-04-26 19:37 ` [PATCH 2/2] Add alarm support to rtc-pcf2123 Howey, Dylan
2019-04-27 13:11 ` Alexandre Belloni
2019-04-27 13:00 ` [PATCH 1/2] Port rtc-pcf2123 to regmap Alexandre Belloni
2019-04-29 15:09 ` Howey, Dylan
2019-04-30 9:22 ` Alexandre Belloni [this message]
2019-05-02 17:45 ` Dylan Howey
2019-05-02 20:55 ` Alexandre Belloni
2019-05-03 13:30 ` Dylan Howey
2019-06-19 13:16 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190430092256.GC11339@piout.net \
--to=alexandre.belloni@bootlin.com \
--cc=Dylan.Howey@tennantco.com \
--cc=a.zummo@towertech.it \
--cc=linux-rtc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).