From: Thierry Reding <thierry.reding@gmail.com>
To: Dmitry Osipenko <digetx@gmail.com>
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>,
Thomas Gleixner <tglx@linutronix.de>,
Alessandro Zummo <a.zummo@towertech.it>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
linux-tegra@vger.kernel.org, linux-rtc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] rtc: tegra: Implement suspend clock source
Date: Fri, 14 Jun 2019 15:42:51 +0200 [thread overview]
Message-ID: <20190614134251.GG15526@ulmo> (raw)
In-Reply-To: <d3de8c42-3718-d87d-3c38-af18c671036c@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1060 bytes --]
On Fri, Jun 14, 2019 at 03:35:14PM +0300, Dmitry Osipenko wrote:
> 14.06.2019 13:47, Thierry Reding пишет:
> > From: Thierry Reding <treding@nvidia.com>
> >
> > The suspend clock source for Tegra210 and earlier is currently
> > implemented in the Tegra timer driver. However, the suspend clock source
> > code accesses registers that are part of the RTC hardware block, so both
> > can step on each others' toes. In practice this isn't an issue, but
> > there is no reason why the RTC driver can't implement the clock source,
> > so move the code over to the tegra-rtc driver.
> >
> > Signed-off-by: Thierry Reding <treding@nvidia.com>
> > ---
>
>
> [snip]
>
> > +static struct tegra_rtc_info *to_tegra_rtc(struct clocksource *clksrc)
> > +{
> > + return container_of(clksrc, struct tegra_rtc_info, clksrc);
> > +}
>
> Shouldn't hurt to inline this function explicitly because I assume that it won't get
> inlined with a certain kernel configurations, like with enabled ftracing for example.
Yeah, makes sense.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-06-14 13:43 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-14 10:47 [PATCH 1/2] clocksource: tegra: Use rating when registering clock source Thierry Reding
2019-06-14 10:47 ` [PATCH 2/2] rtc: tegra: Implement suspend " Thierry Reding
2019-06-14 12:01 ` Dmitry Osipenko
2019-06-14 13:41 ` Thierry Reding
2019-06-14 13:49 ` Dmitry Osipenko
2019-06-14 14:14 ` Thierry Reding
2019-06-14 16:41 ` Dmitry Osipenko
2019-06-17 10:20 ` Thierry Reding
2019-06-17 13:29 ` Dmitry Osipenko
2019-06-14 12:35 ` Dmitry Osipenko
2019-06-14 13:42 ` Thierry Reding [this message]
2019-06-14 12:24 ` [PATCH 1/2] clocksource: tegra: Use rating when registering " Dmitry Osipenko
2019-06-14 13:22 ` Thierry Reding
2019-06-14 13:29 ` Dmitry Osipenko
2019-06-14 13:53 ` Thierry Reding
2019-06-14 14:02 ` Dmitry Osipenko
2019-06-14 14:06 ` Dmitry Osipenko
2019-06-14 15:37 ` Thierry Reding
2019-06-14 17:00 ` Dmitry Osipenko
2019-06-17 10:52 ` Thierry Reding
2019-06-14 14:55 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190614134251.GG15526@ulmo \
--to=thierry.reding@gmail.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=daniel.lezcano@linaro.org \
--cc=digetx@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).