From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Marek Vasut <marex@denx.de>
Cc: linux-rtc@vger.kernel.org
Subject: Re: [PATCH] rtc: abx80x: Implement procfs interface
Date: Sun, 23 Jun 2019 14:38:44 +0200 [thread overview]
Message-ID: <20190623123844.GA3133@piout.net> (raw)
In-Reply-To: <20190623120854.3179-1-marex@denx.de>
Hi Marek,
On 23/06/2019 14:08:54+0200, Marek Vasut wrote:
> Implement procfs interface for polling battery status of the RTC
> via /proc/driver/rtc .
>
Please don't, this interface is deprecated and doesn't work well. Use
RTC_VL_READ instead.
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> ---
> drivers/rtc/rtc-abx80x.c | 24 ++++++++++++++++++++++++
> 1 file changed, 24 insertions(+)
>
> diff --git a/drivers/rtc/rtc-abx80x.c b/drivers/rtc/rtc-abx80x.c
> index 73830670a41f..4fab024fb508 100644
> --- a/drivers/rtc/rtc-abx80x.c
> +++ b/drivers/rtc/rtc-abx80x.c
> @@ -78,6 +78,10 @@
>
> #define ABX8XX_REG_ID0 0x28
>
> +#define ABX8XX_REG_ANA_STATUS 0x2f
> +#define ABX8XX_ANA_BREFD BIT(7)
> +#define ABX8XX_ANA_BMIN BIT(6)
> +
> #define ABX8XX_REG_OUT_CTRL 0x30
> #define ABX8XX_OUT_CTRL_EXDS BIT(4)
>
> @@ -548,6 +552,25 @@ static int abx80x_ioctl(struct device *dev, unsigned int cmd, unsigned long arg)
> }
> }
>
> +static int abx80x_proc(struct device *dev, struct seq_file *seq)
> +{
> + struct i2c_client *client = to_i2c_client(dev);
> + int status, tmp;
> +
> + status = i2c_smbus_read_byte_data(client, ABX8XX_REG_ANA_STATUS);
> + if (status < 0)
> + return status;
> +
> + if (status & ABX8XX_ANA_BREFD)
> + seq_printf(seq, "battery\t\t: ok\n");
> + else if (status & ABX8XX_ANA_BMIN)
> + seq_printf(seq, "battery\t\t: low\n");
> + else
> + seq_printf(seq, "battery\t\t: exhausted\n");
> +
> + return 0;
> +}
> +
> static const struct rtc_class_ops abx80x_rtc_ops = {
> .read_time = abx80x_rtc_read_time,
> .set_time = abx80x_rtc_set_time,
> @@ -555,6 +578,7 @@ static const struct rtc_class_ops abx80x_rtc_ops = {
> .set_alarm = abx80x_set_alarm,
> .alarm_irq_enable = abx80x_alarm_irq_enable,
> .ioctl = abx80x_ioctl,
> + .proc = abx80x_proc,
> };
>
> static int abx80x_dt_trickle_cfg(struct device_node *np)
> --
> 2.20.1
>
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2019-06-23 12:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-23 12:08 [PATCH] rtc: abx80x: Implement procfs interface Marek Vasut
2019-06-23 12:38 ` Alexandre Belloni [this message]
2019-06-23 13:20 ` Marek Vasut
2019-06-29 12:01 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190623123844.GA3133@piout.net \
--to=alexandre.belloni@free-electrons.com \
--cc=linux-rtc@vger.kernel.org \
--cc=marex@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).