From: Lee Jones <lee.jones@linaro.org>
To: Tony Xie <tony.xie@rock-chips.com>
Cc: heiko@sntech.de, broonie@kernel.org, robh+dt@kernel.org,
mark.rutland@arm.com, a.zummo@towertech.it,
alexandre.belloni@bootlin.com, sboyd@kernel.org,
linux-clk@vger.kernel.org, linux-rtc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, chenjh@rock-chips.com,
xsf@rock-chips.com, zhangqing@rock-chips.com,
huangtao@rock-chips.com
Subject: Re: [PATCH v10 1/6] mfd: rk808: remove the id_table
Date: Wed, 26 Jun 2019 12:53:58 +0100 [thread overview]
Message-ID: <20190626115358.GS21119@dell> (raw)
In-Reply-To: <20190621103258.8154-2-tony.xie@rock-chips.com>
On Fri, 21 Jun 2019, Tony Xie wrote:
> Remove the id_table because it's not used.
>
> Signed-off-by: Tony Xie <tony.xie@rock-chips.com>
> ---
> drivers/mfd/rk808.c | 9 ---------
> 1 file changed, 9 deletions(-)
Also, this patch already appears to be applied.
Once patches are taken from the set, you should avoid resending them.
> diff --git a/drivers/mfd/rk808.c b/drivers/mfd/rk808.c
> index 216fbf6adec9..94377782d208 100644
> --- a/drivers/mfd/rk808.c
> +++ b/drivers/mfd/rk808.c
> @@ -568,14 +568,6 @@ static int rk808_remove(struct i2c_client *client)
> return 0;
> }
>
> -static const struct i2c_device_id rk808_ids[] = {
> - { "rk805" },
> - { "rk808" },
> - { "rk818" },
> - { },
> -};
> -MODULE_DEVICE_TABLE(i2c, rk808_ids);
> -
> static struct i2c_driver rk808_i2c_driver = {
> .driver = {
> .name = "rk808",
> @@ -583,7 +575,6 @@ static struct i2c_driver rk808_i2c_driver = {
> },
> .probe = rk808_probe,
> .remove = rk808_remove,
> - .id_table = rk808_ids,
> };
>
> module_i2c_driver(rk808_i2c_driver);
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2019-06-26 11:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-21 10:32 [PATCH v10 0/6] support a new type of PMIC,including two chips(rk817 and rk809) Tony Xie
2019-06-21 10:32 ` [PATCH v10 1/6] mfd: rk808: remove the id_table Tony Xie
2019-06-26 11:53 ` Lee Jones [this message]
2019-06-21 10:32 ` [PATCH v10 2/6] mfd: rk808: Add RK817 and RK809 support Tony Xie
2019-06-21 10:32 ` [PATCH v10 3/6] regulator: rk808: add RK809 and RK817 support Tony Xie
2019-06-26 12:29 ` [PATCH v10.1 " Heiko Stuebner
2019-06-21 10:32 ` [PATCH v10 4/6] dt-bindings: mfd: rk808: Add binding information for RK809 and RK817 Tony Xie
2019-06-21 10:34 ` [PATCH v10 5/6] rtc: rk808: add RK809 and RK817 support Tony Xie
2019-06-21 10:34 ` [PATCH v10 6/6] clk: RK808: " Tony Xie
2019-06-26 11:52 ` [PATCH v10 0/6] support a new type of PMIC,including two chips(rk817 and rk809) Lee Jones
2019-06-27 8:18 ` Heiko Stuebner
2019-06-27 13:59 ` [GIT PULL] Immutable branch between MFD, Clk, Regulator and RTC due for the v5.3 merge window Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190626115358.GS21119@dell \
--to=lee.jones@linaro.org \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=broonie@kernel.org \
--cc=chenjh@rock-chips.com \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=huangtao@rock-chips.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-rtc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=tony.xie@rock-chips.com \
--cc=xsf@rock-chips.com \
--cc=zhangqing@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).