From: Thomas Bogendoerfer <tbogendoerfer@suse.de>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: Jakub Kicinski <jakub.kicinski@netronome.com>,
Jonathan Corbet <corbet@lwn.net>,
Ralf Baechle <ralf@linux-mips.org>,
Paul Burton <paul.burton@mips.com>,
James Hogan <jhogan@kernel.org>, Lee Jones <lee.jones@linaro.org>,
"David S. Miller" <davem@davemloft.net>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Alessandro Zummo <a.zummo@towertech.it>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jslaby@suse.com>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mips@vger.kernel.org, netdev@vger.kernel.org,
linux-rtc@vger.kernel.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH v9 5/5] MIPS: SGI-IP27: Enable ethernet phy on second Origin 200 module
Date: Fri, 11 Oct 2019 11:28:04 +0200 [thread overview]
Message-ID: <20191011112804.ef8079aa9bad5c81ce473fbd@suse.de> (raw)
In-Reply-To: <102db20a-0c37-3e28-2d14-e9c6eaa55f5c@cogentembedded.com>
On Thu, 10 Oct 2019 19:37:15 +0300
Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> wrote:
> On 10/10/2019 05:59 PM, Thomas Bogendoerfer wrote:
> > + /* enable ethernet PHY on IP29 systemboard */
> > + pci_read_config_dword(dev, PCI_SUBSYSTEM_VENDOR_ID, &sid);
> > + if (sid == ((PCI_VENDOR_ID_SGI << 16) | IOC3_SUBSYS_IP29_SYSBOARD))
>
> I thought PCI was little endian, thuis vendor ID at offset 0 and device ID
> at offset 2?
you are right. I already messed it up in pci-xtalk-bridge.c. As this is just a
fake sub device id, there is no harm, but I'll fix it.
Thomas.
--
SUSE Software Solutions Germany GmbH
HRB 247165 (AG München)
Geschäftsführer: Felix Imendörffer
prev parent reply other threads:[~2019-10-11 9:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-10 14:59 [PATCH v9 0/5] Use MFD framework for SGI IOC3 drivers Thomas Bogendoerfer
2019-10-10 14:59 ` [PATCH v9 1/5] nvmem: core: add nvmem_device_find Thomas Bogendoerfer
2019-10-10 14:59 ` [PATCH v9 2/5] MIPS: PCI: use information from 1-wire PROM for IOC3 detection Thomas Bogendoerfer
2019-10-10 14:59 ` [PATCH v9 3/5] mfd: ioc3: Add driver for SGI IOC3 chip Thomas Bogendoerfer
2019-10-11 3:00 ` Jakub Kicinski
2019-10-11 8:37 ` Thomas Bogendoerfer
2019-10-10 14:59 ` [PATCH v9 4/5] MIPS: SGI-IP27: fix readb/writeb addressing Thomas Bogendoerfer
2019-10-10 14:59 ` [PATCH v9 5/5] MIPS: SGI-IP27: Enable ethernet phy on second Origin 200 module Thomas Bogendoerfer
2019-10-10 16:37 ` Sergei Shtylyov
2019-10-11 9:28 ` Thomas Bogendoerfer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191011112804.ef8079aa9bad5c81ce473fbd@suse.de \
--to=tbogendoerfer@suse.de \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=jakub.kicinski@netronome.com \
--cc=jhogan@kernel.org \
--cc=jslaby@suse.com \
--cc=lee.jones@linaro.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=paul.burton@mips.com \
--cc=ralf@linux-mips.org \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).