From: Rob Herring <robh@kernel.org>
To: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
Cc: mazziesaccount@gmail.com, Lee Jones <lee.jones@linaro.org>,
Jacek Anaszewski <jacek.anaszewski@gmail.com>,
Pavel Machek <pavel@ucw.cz>, Dan Murphy <dmurphy@ti.com>,
Mark Rutland <mark.rutland@arm.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jonathan Corbet <corbet@lwn.net>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Alessandro Zummo <a.zummo@towertech.it>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
Nicholas Mc Guire <hofrat@osadl.org>,
Phil Edworthy <phil.edworthy@renesas.com>,
linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-rtc@vger.kernel.org
Subject: Re: [PATCH v5 03/16] dt-bindings: mfd: Document ROHM BD71828 bindings
Date: Fri, 22 Nov 2019 17:05:14 -0600 [thread overview]
Message-ID: <20191122230514.GB15812@bogus> (raw)
In-Reply-To: <00abd88e370ec155b0717413d324a1c96c01a13d.1574059625.git.matti.vaittinen@fi.rohmeurope.com>
On Mon, Nov 18, 2019 at 08:54:56AM +0200, Matti Vaittinen wrote:
> ROHM BD71828 Power management IC integrates 7 buck converters, 7 LDOs,
> a real-time clock (RTC), 3 GPO/regulator control pins, HALL input
> and a 32.768 kHz clock gate.
>
> Document the dt bindings drivers are using.
>
> Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
> ---
>
> No changes from v4
>
> .../bindings/mfd/rohm,bd71828-pmic.yaml | 249 ++++++++++++++++++
> 1 file changed, 249 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/mfd/rohm,bd71828-pmic.yaml
>
> diff --git a/Documentation/devicetree/bindings/mfd/rohm,bd71828-pmic.yaml b/Documentation/devicetree/bindings/mfd/rohm,bd71828-pmic.yaml
> new file mode 100644
> index 000000000000..17ea9fa463e8
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/rohm,bd71828-pmic.yaml
> @@ -0,0 +1,249 @@
> +# SPDX-License-Identifier: GPL-2.0-only
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/mfd/rohm,bd71828-pmic.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: ROHM BD71828 Power Management Integrated Circuit bindings
> +
> +maintainers:
> + - Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
> +
> +description: |
> + BD71828GW is a single-chip power management IC for battery-powered portable
> + devices. The IC integrates 7 buck converters, 7 LDOs, and a 1500 mA
> + single-cell linear charger. Also included is a Coulomb counter, a real-time
> + clock (RTC), and a 32.768 kHz clock gate.
> +
> + The BD71828 RUN state is divided into 4 configurable run-levels named RUN0,
> + RUN1, RUN2 and RUN3. Bucks 1, 2, 6 and 7 can be either controlled individually
> + via I2C, or some/all of them can be bound to run-levels and controlled as a
> + group. If bucks are controlled individually these run-levels are ignored. See
> + ../regulator/rohm,bd71828-regulator.yaml for how to define regulator voltages
> + for run-levels. Run-levels can be changed by I2C or GPIO depending on PMIC's
> + OTP configuration.
> +
> +properties:
> + compatible:
> + const: rohm,bd71828
> +
> + reg:
> + description:
> + I2C slave address.
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> + description:
> + The interrupt line the device is connected to.
The description here is not too useful, I'd drop it.
> +
> + gpio-controller: true
> + # Indicate BD71828 acts as a GPIO controller.
> +
> + "#gpio-cells":
> + const: 2
> + description: |
> + The first cell is the pin number and the second cell is used to specify
> + flags. See ../gpio/gpio.txt for more information.
> +
> + clocks:
> + maxItems: 1
> + description:
> + The parent clock connected to PMIC.
The description here is not too useful, I'd drop it.
> +
> + "#clock-cells":
> + const: 0
> +
> + rohm,charger-sense-resistor-ohms:
> + minimum: 10000000
> + maximum: 50000000
> + description: |
> + BD71827 and BD71828 have SAR ADC for measuring charging currents.
> + External sense resistor (RSENSE in data sheet) should be used. If some
> + other but 30MOhm resistor is used the resistance value should be given
> + here in Ohms.
> +
> + regulators:
> + $ref: ../regulator/rohm,bd71828-regulator.yaml
> + description:
> + List of child nodes that specify the regulators.
> +
> + leds:
> + $ref: ../leds/rohm,bd71828-leds.yaml
> +
> + rohm,dvs-vsel-gpios:
> + maxItems: 2
> + description: |
> + GPIOs used to control PMIC run-levels. Should describe two GPIOs.
> + (See run-level control in data-sheet). If this property is omitted but
> + some bucks are marked to be controlled by run-levels - then OTP option
> + allowing run-level control via I2C is assumed.
> +
> + gpio-reserved-ranges:
> + description: |
> + Usage of BD71828 GPIO pins can be changed via OTP. This property can be
> + used to mark the pins which should not be configured for GPIO. Please see
> + the ../gpio/gpio.txt for more information.
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - clocks
> + - "#clock-cells"
> + - regulators
> + - gpio-controller
> + - "#gpio-cells"
next prev parent reply other threads:[~2019-11-22 23:06 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-18 6:53 [PATCH v5 00/16] Support ROHM BD71828 PMIC Matti Vaittinen
2019-11-18 6:53 ` [PATCH v5 01/16] dt-bindings: regulator: Document ROHM BD71282 regulator bindings Matti Vaittinen
2019-11-18 16:25 ` Mark Brown
2019-11-18 18:03 ` Vaittinen, Matti
2019-11-19 18:13 ` Mark Brown
2019-11-19 18:51 ` Vaittinen, Matti
2019-11-19 19:36 ` Mark Brown
2019-11-29 7:48 ` Vaittinen, Matti
2019-11-29 12:09 ` Mark Brown
2019-12-02 7:57 ` Vaittinen, Matti
2019-12-02 13:11 ` Mark Brown
2019-12-02 14:02 ` Vaittinen, Matti
2019-12-04 12:47 ` Mark Brown
2019-12-04 13:13 ` Vaittinen, Matti
2019-12-04 14:14 ` Mark Brown
2019-12-10 10:39 ` Vaittinen, Matti
2019-12-10 11:14 ` Vaittinen, Matti
2019-12-10 12:11 ` Mark Brown
2019-12-10 12:41 ` Vaittinen, Matti
2019-12-10 12:45 ` Mark Brown
2019-12-10 13:07 ` Vaittinen, Matti
2019-11-22 22:48 ` Rob Herring
2019-11-18 6:54 ` [PATCH v5 02/16] dt-bindings: leds: ROHM BD71282 PMIC LED driver Matti Vaittinen
2019-11-22 23:00 ` Rob Herring
2019-11-18 6:54 ` [PATCH v5 03/16] dt-bindings: mfd: Document ROHM BD71828 bindings Matti Vaittinen
2019-11-22 23:05 ` Rob Herring [this message]
2019-11-18 6:55 ` [PATCH v5 04/16] mfd: rohm PMICs - use platform_device_id to match MFD sub-devices Matti Vaittinen
2019-11-18 6:55 ` [PATCH v5 05/16] mfd: bd71828: Support ROHM BD71828 PMIC - core Matti Vaittinen
2019-11-18 6:56 ` [PATCH v5 06/16] mfd: input: bd71828: Add power-key support Matti Vaittinen
2019-11-18 6:56 ` [PATCH v5 07/16] clk: bd718x7: Support ROHM BD71828 clk block Matti Vaittinen
2019-11-18 6:57 ` [PATCH v5 08/16] regulator: bd718x7: Split driver to common and bd718x7 specific parts Matti Vaittinen
2019-11-18 6:57 ` [PATCH v5 09/16] regulator: bd71828: Basic support for ROHM bd71828 PMIC regulators Matti Vaittinen
2019-11-18 16:20 ` Mark Brown
2019-11-19 9:12 ` Vaittinen, Matti
2019-11-18 6:58 ` [PATCH v5 10/16] gpio: devres: Add devm_gpiod_get_parent_array Matti Vaittinen
2019-11-19 14:43 ` Linus Walleij
2019-11-19 17:54 ` Vaittinen, Matti
2019-11-21 14:13 ` Linus Walleij
2019-11-18 6:59 ` [PATCH v5 11/16] docs: driver-model: Add missing managed GPIO array get functions Matti Vaittinen
2019-11-18 6:59 ` [PATCH v5 12/16] regulator: bd71828: Add GPIO based run-level control for regulators Matti Vaittinen
2019-11-18 7:00 ` [PATCH v5 13/16] rtc: bd70528 add BD71828 support Matti Vaittinen
2019-12-10 13:24 ` Alexandre Belloni
2019-11-18 7:01 ` [PATCH v5 14/16] gpio: bd71828: Initial support for ROHM BD71828 PMIC GPIOs Matti Vaittinen
2019-11-18 9:22 ` Bartosz Golaszewski
2019-11-18 7:03 ` [PATCH v5 15/16] leds: Add common LED binding parsing support to LED class/core Matti Vaittinen
2019-11-18 21:55 ` Jacek Anaszewski
2019-11-19 7:21 ` Vaittinen, Matti
2019-11-19 19:30 ` Jacek Anaszewski
2019-11-20 7:31 ` Vaittinen, Matti
2019-11-19 14:23 ` Vaittinen, Matti
2019-11-18 7:03 ` [PATCH v5 16/16] led: bd71828: Support LED outputs on ROHM BD71828 PMIC Matti Vaittinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191122230514.GB15812@bogus \
--to=robh@kernel.org \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=bgolaszewski@baylibre.com \
--cc=broonie@kernel.org \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=hkallweit1@gmail.com \
--cc=hofrat@osadl.org \
--cc=jacek.anaszewski@gmail.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mark.rutland@arm.com \
--cc=matti.vaittinen@fi.rohmeurope.com \
--cc=mazziesaccount@gmail.com \
--cc=mchehab+samsung@kernel.org \
--cc=mturquette@baylibre.com \
--cc=pavel@ucw.cz \
--cc=phil.edworthy@renesas.com \
--cc=sboyd@kernel.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).