From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Alessandro Zummo <a.zummo@towertech.it>,
Akinobu Mita <akinobu.mita@gmail.com>,
Joe Perches <joe@perches.com>,
linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rtc: i2c/spi: Avoid inclusion of REGMAP support when not needed
Date: Mon, 27 Jan 2020 23:45:49 +0100 [thread overview]
Message-ID: <20200127224549.GC3273@piout.net> (raw)
In-Reply-To: <20200112171349.22268-1-geert@linux-m68k.org>
On 12/01/2020 18:13:49+0100, Geert Uytterhoeven wrote:
> Merely enabling I2C and RTC selects REGMAP_I2C and REGMAP_SPI, even when
> no driver needs it. While the former can be moduler, the latter cannot,
> and thus becomes built-in.
>
> Fix this by moving the select statements for REGMAP_I2C and REGMAP_SPI
> from the RTC_I2C_AND_SPI helper to the individual drivers that depend on
> it.
>
> Note that the comment for RTC_I2C_AND_SPI refers to SND_SOC_I2C_AND_SPI
> for more information, but the latter does not select REGMAP_{I2C,SPI}
> itself, and defers that to the individual drivers, too.
>
> Fixes: 080481f54ef62121 ("rtc: merge ds3232 and ds3234")
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
> Joe: When merging addresses, scripts/get_maintainer.pl replaces
> Alexandre's authoritative email address from MAINTAINERS by the
> obsolete address in the SoB-line of the commit referred to by the
> Fixes-line.
>
> drivers/rtc/Kconfig | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
Applied, thanks.
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2020-01-27 22:45 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-12 17:13 [PATCH] rtc: i2c/spi: Avoid inclusion of REGMAP support when not needed Geert Uytterhoeven
2020-01-12 21:45 ` kbuild test robot
2020-01-13 1:29 ` kbuild test robot
2020-01-13 6:36 ` Joe Perches
2020-01-13 7:25 ` Geert Uytterhoeven
2020-01-13 7:40 ` Joe Perches
2020-01-13 7:57 ` Geert Uytterhoeven
2020-01-13 8:12 ` Joe Perches
2020-01-14 10:13 ` Geert Uytterhoeven
2020-01-27 22:45 ` Alexandre Belloni [this message]
2020-01-28 8:33 ` Geert Uytterhoeven
2020-01-28 8:50 ` Alexandre Belloni
2020-01-28 8:59 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200127224549.GC3273@piout.net \
--to=alexandre.belloni@bootlin.com \
--cc=a.zummo@towertech.it \
--cc=akinobu.mita@gmail.com \
--cc=geert@linux-m68k.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).