From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Prashant Malani <pmalani@chromium.org>
Cc: linux-kernel@vger.kernel.org,
Alessandro Zummo <a.zummo@towertech.it>,
Benson Leung <bleung@chromium.org>,
Enric Balletbo i Serra <enric.balletbo@collabora.com>,
Guenter Roeck <groeck@chromium.org>,
"open list:REAL TIME CLOCK (RTC) SUBSYSTEM"
<linux-rtc@vger.kernel.org>
Subject: Re: [PATCH v2 14/17] rtc: cros-ec: Use cros_ec_cmd()
Date: Wed, 5 Feb 2020 21:04:44 +0100 [thread overview]
Message-ID: <20200205200444.GC3290@piout.net> (raw)
In-Reply-To: <20200205190028.183069-15-pmalani@chromium.org>
On 05/02/2020 11:00:22-0800, Prashant Malani wrote:
> Replace cros_ec_cmd_xfer_status() with cros_ec_cmd() which does the
> message buffer setup and cleanup.
>
> Signed-off-by: Prashant Malani <pmalani@chromium.org>
Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
> ---
>
> Changes in v2:
> - Updated to use new function name and parameter list.
>
> drivers/rtc/rtc-cros-ec.c | 27 ++++++++-------------------
> 1 file changed, 8 insertions(+), 19 deletions(-)
>
> diff --git a/drivers/rtc/rtc-cros-ec.c b/drivers/rtc/rtc-cros-ec.c
> index f7343c289cab73..6886100ad0b8b7 100644
> --- a/drivers/rtc/rtc-cros-ec.c
> +++ b/drivers/rtc/rtc-cros-ec.c
> @@ -33,16 +33,11 @@ static int cros_ec_rtc_get(struct cros_ec_device *cros_ec, u32 command,
> u32 *response)
> {
> int ret;
> - struct {
> - struct cros_ec_command msg;
> - struct ec_response_rtc data;
> - } __packed msg;
>
> - memset(&msg, 0, sizeof(msg));
> - msg.msg.command = command;
> - msg.msg.insize = sizeof(msg.data);
> + struct ec_response_rtc data = {0};
>
> - ret = cros_ec_cmd_xfer_status(cros_ec, &msg.msg);
> + ret = cros_ec_cmd(cros_ec, 0, command, NULL, 0, &data, sizeof(data),
> + NULL);
> if (ret < 0) {
> dev_err(cros_ec->dev,
> "error getting %s from EC: %d\n",
> @@ -51,7 +46,7 @@ static int cros_ec_rtc_get(struct cros_ec_device *cros_ec, u32 command,
> return ret;
> }
>
> - *response = msg.data.time;
> + *response = data.time;
>
> return 0;
> }
> @@ -60,17 +55,11 @@ static int cros_ec_rtc_set(struct cros_ec_device *cros_ec, u32 command,
> u32 param)
> {
> int ret = 0;
> - struct {
> - struct cros_ec_command msg;
> - struct ec_response_rtc data;
> - } __packed msg;
> + struct ec_response_rtc data;
>
> - memset(&msg, 0, sizeof(msg));
> - msg.msg.command = command;
> - msg.msg.outsize = sizeof(msg.data);
> - msg.data.time = param;
> -
> - ret = cros_ec_cmd_xfer_status(cros_ec, &msg.msg);
> + data.time = param;
> + ret = cros_ec_cmd(cros_ec, 0, command, &data, sizeof(data), NULL, 0,
> + NULL);
> if (ret < 0) {
> dev_err(cros_ec->dev, "error setting %s on EC: %d\n",
> command == EC_CMD_RTC_SET_VALUE ? "time" : "alarm",
> --
> 2.25.0.341.g760bfbb309-goog
>
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2020-02-05 20:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200205190028.183069-1-pmalani@chromium.org>
2020-02-05 19:00 ` [PATCH v2 14/17] rtc: cros-ec: Use cros_ec_cmd() Prashant Malani
2020-02-05 20:04 ` Alexandre Belloni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200205200444.GC3290@piout.net \
--to=alexandre.belloni@bootlin.com \
--cc=a.zummo@towertech.it \
--cc=bleung@chromium.org \
--cc=enric.balletbo@collabora.com \
--cc=groeck@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=pmalani@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).