From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Claudiu Beznea <claudiu.beznea@microchip.com>
Cc: a.zummo@towertech.it, robh+dt@kernel.org, mark.rutland@arm.com,
nicolas.ferre@microchip.com, ludovic.desroches@microchip.com,
tglx@linutronix.de, jason@lakedaemon.net, maz@kernel.org,
linux-rtc@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/5] ARM: dts: sam9x60: add rtt
Date: Sat, 11 Apr 2020 00:26:58 +0200 [thread overview]
Message-ID: <20200410222658.GB3628@piout.net> (raw)
In-Reply-To: <1586536019-12348-5-git-send-email-claudiu.beznea@microchip.com>
On 10/04/2020 19:26:58+0300, Claudiu Beznea wrote:
> Add RTT.
>
> Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
> ---
> arch/arm/boot/dts/at91-sam9x60ek.dts | 5 +++++
> arch/arm/boot/dts/sam9x60.dtsi | 7 +++++++
> 2 files changed, 12 insertions(+)
>
> diff --git a/arch/arm/boot/dts/at91-sam9x60ek.dts b/arch/arm/boot/dts/at91-sam9x60ek.dts
> index ab3d2d9a420a..4020e79a958e 100644
> --- a/arch/arm/boot/dts/at91-sam9x60ek.dts
> +++ b/arch/arm/boot/dts/at91-sam9x60ek.dts
> @@ -617,6 +617,11 @@
> };
> };
>
> +&rtt {
> + atmel,rtt-rtc-time-reg = <&gpbr 0x0>;
> + status = "okay";
Is there any point using a gpbr register while there is already a much
better RTC in the system?
In any case, this diff should be merge with the other at91-sam9x60ek.dts
change instead of being with the dtsi change.
> +};
> +
> &shutdown_controller {
> atmel,shdwc-debouncer = <976>;
> status = "okay";
> diff --git a/arch/arm/boot/dts/sam9x60.dtsi b/arch/arm/boot/dts/sam9x60.dtsi
> index 326b39328b58..e1d8e3a4cb0b 100644
> --- a/arch/arm/boot/dts/sam9x60.dtsi
> +++ b/arch/arm/boot/dts/sam9x60.dtsi
> @@ -661,6 +661,13 @@
> status = "disabled";
> };
>
> + rtt: rtt@fffffe20 {
> + compatible = "microchip,sam9x60-rtt";
> + reg = <0xfffffe20 0x20>;
> + interrupts = <1 IRQ_TYPE_LEVEL_HIGH 7>;
> + clocks = <&clk32k 0>;
> + };
> +
> pit: timer@fffffe40 {
> compatible = "atmel,at91sam9260-pit";
> reg = <0xfffffe40 0x10>;
> --
> 2.7.4
>
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2020-04-10 22:27 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-10 16:26 [PATCH 0/5] add RTT support for SAM9X60 Claudiu Beznea
2020-04-10 16:26 ` [PATCH 1/5] irqchip/atmel-aic5: add support for sam9x60 rtt fixup Claudiu Beznea
2020-04-10 16:26 ` [PATCH 2/5] rtc: at91sam9: enable driver for sam9x60 Claudiu Beznea
2020-04-10 16:26 ` [PATCH 3/5] ARM: dts: sam9x60ek: enable gpbr Claudiu Beznea
2020-04-10 16:26 ` [PATCH 4/5] ARM: dts: sam9x60: add rtt Claudiu Beznea
2020-04-10 22:26 ` Alexandre Belloni [this message]
2020-04-13 8:51 ` Claudiu.Beznea
2020-04-13 10:46 ` Alexandre Belloni
2020-04-14 8:42 ` Claudiu.Beznea
2020-04-14 11:16 ` Alexandre Belloni
2020-04-14 12:13 ` Claudiu.Beznea
2020-04-14 12:47 ` Alexandre Belloni
2020-04-14 13:05 ` Claudiu.Beznea
2020-04-14 13:12 ` Alexandre Belloni
2020-04-14 13:59 ` Claudiu.Beznea
2020-04-10 16:26 ` [PATCH 5/5] rtc: at91sam9: add microchip,sam9x60-rtt Claudiu Beznea
2020-04-10 17:41 ` Alexandre Belloni
2020-04-13 8:50 ` Claudiu.Beznea
2020-04-13 10:41 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200410222658.GB3628@piout.net \
--to=alexandre.belloni@bootlin.com \
--cc=a.zummo@towertech.it \
--cc=claudiu.beznea@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=ludovic.desroches@microchip.com \
--cc=mark.rutland@arm.com \
--cc=maz@kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=robh+dt@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).