linux-rtc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Biwen Li <biwen.li@oss.nxp.com>
To: leoyang.li@nxp.com, robh+dt@kernel.org, mpe@ellerman.id.au,
	benh@kernel.crashing.org, a.zummo@towertech.it,
	alexandre.belloni@bootlin.com
Cc: devicetree@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
	linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org,
	Biwen Li <biwen.li@nxp.com>
Subject: [PATCH 3/3] dts: ppc: t1024rdb: add wakeup-source property to drop warning
Date: Fri,  8 May 2020 13:49:25 +0800	[thread overview]
Message-ID: <20200508054925.48237-3-biwen.li@oss.nxp.com> (raw)
In-Reply-To: <20200508054925.48237-1-biwen.li@oss.nxp.com>

From: Biwen Li <biwen.li@nxp.com>

This adds wakeup-source property to drop warning as follows:
    - $ hwclock.util-linux
      hwclock.util-linux: select() to /dev/rtc0
      to wait for clock tick timed out

My case:
    - RTC ds1339s INT pin isn't connected to cpus INT pin on T1024RDB,
      then the RTC cannot inform cpu about alarm interrupt

How to fix it?
    - add wakeup-source property and remove IRQ line
      to set uie_unsupported flag

Signed-off-by: Biwen Li <biwen.li@nxp.com>
---
 arch/powerpc/boot/dts/fsl/t1024rdb.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/powerpc/boot/dts/fsl/t1024rdb.dts b/arch/powerpc/boot/dts/fsl/t1024rdb.dts
index 645caff98ed1..191cbf5cda4e 100644
--- a/arch/powerpc/boot/dts/fsl/t1024rdb.dts
+++ b/arch/powerpc/boot/dts/fsl/t1024rdb.dts
@@ -161,7 +161,7 @@
 			rtc@68 {
 				compatible = "dallas,ds1339";
 				reg = <0x68>;
-				interrupts = <0x1 0x1 0 0>;
+				wakeup-source;
 			};
 		};
 
-- 
2.17.1


  parent reply	other threads:[~2020-05-08  5:54 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-08  5:49 [PATCH 1/3] rtc: ds1374: add uie_unsupported property to drop warning Biwen Li
2020-05-08  5:49 ` [PATCH 2/3] dts: ppc: t4240rdb: " Biwen Li
2020-05-08 11:50   ` Alexandre Belloni
2020-05-08 11:59     ` Biwen Li (OSS)
2020-05-08  5:49 ` Biwen Li [this message]
2020-05-08 11:49 ` [PATCH 1/3] rtc: ds1374: " Alexandre Belloni
2020-05-08 11:59   ` Biwen Li (OSS)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200508054925.48237-3-biwen.li@oss.nxp.com \
    --to=biwen.li@oss.nxp.com \
    --cc=a.zummo@towertech.it \
    --cc=alexandre.belloni@bootlin.com \
    --cc=benh@kernel.crashing.org \
    --cc=biwen.li@nxp.com \
    --cc=devicetree@vger.kernel.org \
    --cc=leoyang.li@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rtc@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mpe@ellerman.id.au \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).