From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: "Kevin P. Fleming" <kevin+linux@km6g.us>
Cc: Alessandro Zummo <a.zummo@towertech.it>, linux-rtc@vger.kernel.org
Subject: Re: [PATCH] rtc: abx80x: Provide feedback for invalid dt properties
Date: Fri, 29 May 2020 10:54:52 +0200 [thread overview]
Message-ID: <20200529085452.GZ3972@piout.net> (raw)
In-Reply-To: <20200529001203.235304-1-kevin+linux@km6g.us>
Hi,
On 28/05/2020 20:12:03-0400, Kevin P. Fleming wrote:
> When the user provides an invalid value for tc-diode or
> tc-resistor generate an error message instead of silently
> ignoring it.
>
> Signed-off-by: Kevin P. Fleming <kevin+linux@km6g.us>
> ---
> drivers/rtc/rtc-abx80x.c | 17 +++++++++++------
> 1 file changed, 11 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/rtc/rtc-abx80x.c b/drivers/rtc/rtc-abx80x.c
> index 3521d8e8dc38..dae046e3484a 100644
> --- a/drivers/rtc/rtc-abx80x.c
> +++ b/drivers/rtc/rtc-abx80x.c
> @@ -554,7 +554,8 @@ static const struct rtc_class_ops abx80x_rtc_ops = {
> .ioctl = abx80x_ioctl,
> };
>
> -static int abx80x_dt_trickle_cfg(struct device_node *np)
> +static int abx80x_dt_trickle_cfg(struct i2c_client *client,
> + struct device_node *np)
I would remove np from the parameters and use
struct device_node *np = client->dev.of_node;
in the function.
> {
> const char *diode;
> int trickle_cfg = 0;
> @@ -565,12 +566,14 @@ static int abx80x_dt_trickle_cfg(struct device_node *np)
> if (ret)
> return ret;
>
> - if (!strcmp(diode, "standard"))
> + if (!strcmp(diode, "standard")) {
> trickle_cfg |= ABX8XX_TRICKLE_STANDARD_DIODE;
> - else if (!strcmp(diode, "schottky"))
> + } else if (!strcmp(diode, "schottky")) {
> trickle_cfg |= ABX8XX_TRICKLE_SCHOTTKY_DIODE;
> - else
> + } else {
> + dev_err(&client->dev, "Invalid tc-diode value: %s\n", diode);
Can you make that dev_dbg? This is only ever needed at board bring up/
development time, so it is not necessary to bloat the kernel with more
strings.
> return -EINVAL;
> + }
>
> ret = of_property_read_u32(np, "abracon,tc-resistor", &tmp);
> if (ret)
> @@ -580,8 +583,10 @@ static int abx80x_dt_trickle_cfg(struct device_node *np)
> if (trickle_resistors[i] == tmp)
> break;
>
> - if (i == sizeof(trickle_resistors))
> + if (i == sizeof(trickle_resistors)) {
> + dev_err(&client->dev, "Invalid tc-resistor value: %u\n", tmp);
> return -EINVAL;
> + }
>
> return (trickle_cfg | i);
> }
> @@ -793,7 +798,7 @@ static int abx80x_probe(struct i2c_client *client,
> }
>
> if (np && abx80x_caps[part].has_tc)
> - trickle_cfg = abx80x_dt_trickle_cfg(np);
> + trickle_cfg = abx80x_dt_trickle_cfg(client, np);
>
> if (trickle_cfg > 0) {
> dev_info(&client->dev, "Enabling trickle charger: %02x\n",
> --
> 2.26.2
>
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2020-05-29 8:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-29 0:12 [PATCH] rtc: abx80x: Provide feedback for invalid dt properties Kevin P. Fleming
2020-05-29 8:54 ` Alexandre Belloni [this message]
2020-05-29 10:28 ` Kevin P. Fleming
2020-05-29 13:16 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200529085452.GZ3972@piout.net \
--to=alexandre.belloni@bootlin.com \
--cc=a.zummo@towertech.it \
--cc=kevin+linux@km6g.us \
--cc=linux-rtc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).