From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: "Johnson CH Chen (陳昭勳)" <JohnsonCH.Chen@moxa.com>
Cc: Wim Van Sebroeck <wim@linux-watchdog.org>,
Alessandro Zummo <a.zummo@towertech.it>,
"linux@roeck-us.net" <linux@roeck-us.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-rtc@vger.kernel.org" <linux-rtc@vger.kernel.org>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Randy Dunlap <rdunlap@infradead.org>
Subject: Re: [PATCH v5] rtc: rtc-ds1374: wdt: Use watchdog core for watchdog part
Date: Mon, 20 Jul 2020 14:28:05 +0200 [thread overview]
Message-ID: <20200720122805.GH3428@piout.net> (raw)
In-Reply-To: <HK2PR01MB3281AE06720A1C7013603B07FA7B0@HK2PR01MB3281.apcprd01.prod.exchangelabs.com>
On 20/07/2020 10:44:41+0000, Johnson CH Chen (陳昭勳) wrote:
> Hi Alexandre,
>
> > > v4->v5:
> > > - Fix reported build error by replacing RTC_DRV_DS1374_WDT with
> > > WATCHDOG_CORE
> > >
> >
> > This is not the correct solution as this will remove the alarm functionality for
> > anyone enabling WATCHDOG. I already submitted a proper fix.
> >
>
> It's an appropriate and better solution. Thanks!
>
> RTC_DRV_DS1374_WDT still should select WATCHDOG_CORE to avoid build error if WATCHDOG_CORE is set to "m", and it should be depended on RTC_DRV_DS1374 and WATCHDOG.
>
My patch handles that properly, RTC_DRV_DS1374_WDT still selects WATCHDOG_CORE
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2020-07-20 12:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-20 9:46 [PATCH v5] rtc: rtc-ds1374: wdt: Use watchdog core for watchdog part Johnson CH Chen (陳昭勳)
2020-07-20 10:26 ` Alexandre Belloni
2020-07-20 10:44 ` Johnson CH Chen (陳昭勳)
2020-07-20 12:28 ` Alexandre Belloni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200720122805.GH3428@piout.net \
--to=alexandre.belloni@bootlin.com \
--cc=JohnsonCH.Chen@moxa.com \
--cc=a.zummo@towertech.it \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=rdunlap@infradead.org \
--cc=sfr@canb.auug.org.au \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).