From: Roman Stratiienko <roman.stratiienko@globallogic.com>
To: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: a.zummo@towertech.it, linux-rtc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rtc: test: enable wakeup flags
Date: Wed, 15 May 2019 16:53:57 +0300 [thread overview]
Message-ID: <CAODwZ7t1UgPMeMYcadALD_gCa1Zp1fq65oF9fL65u5DTTft0Sw@mail.gmail.com> (raw)
In-Reply-To: <CAODwZ7vuBndm2i7CFm0RT1wM3phyQkQ+g0Gyjb1GE7k1-bHccQ@mail.gmail.com>
Hi Alexandre,
Thank you for the review.
See my answers below.
On Wed, May 15, 2019 at 3:32 PM Alexandre Belloni
<alexandre.belloni@bootlin.com> wrote:
>
> Hi,
>
> (You didn't use my correct email address, please update your kernel)
Fixed.
>
> On 15/05/2019 14:14:36+0300, roman.stratiienko@globallogic.com wrote:
> > From: Roman Stratiienko <roman.stratiienko@globallogic.com>
> >
> > Alarmtimer interface uses only the RTC with wekeup flags enabled.
> > Allow to use rtc-test driver with alarmtimer interface.
> >
> > Signed-off-by: Roman Stratiienko <roman.stratiienko@globallogic.com>
> > ---
> > drivers/rtc/rtc-test.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/rtc/rtc-test.c b/drivers/rtc/rtc-test.c
> > index 6c5f09c815e8..c839ae575c77 100644
> > --- a/drivers/rtc/rtc-test.c
> > +++ b/drivers/rtc/rtc-test.c
> > @@ -123,6 +123,8 @@ static int test_probe(struct platform_device *plat_dev)
> >
> > platform_set_drvdata(plat_dev, rtd);
> >
> > + device_init_wakeup(&plat_dev->dev, 1);
> > +
>
> The first created RTC doesn't have any alarm, so this must not be done
> for all the devices.
Thanks. I will fix this in v2.
>
> Also, this driver will never wake up the platform so I'm not sure it is
> relevant to test alarmtimers.
Alarmtimer interface relies only on RTC with alarm support,
but it also checks wake flags for some reason.
As far as rtc-test driver do have alarm support, I expect
that related drivers should use it.
Let me share some information about my use-case:
Alarmtimer support is required for generic AOSP bluedroid library.
To enable Bluetooth in Android on the devices that does not
have hardware RTC, enabling rtc-test driver is a good option.
>
> --
> Alexandre Belloni, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
--
Best regards,
Roman Stratiienko
Global Logic Inc.
prev parent reply other threads:[~2019-05-15 13:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-15 11:14 [PATCH] rtc: test: enable wakeup flags roman.stratiienko
2019-05-15 12:32 ` Alexandre Belloni
[not found] ` <CAODwZ7vuBndm2i7CFm0RT1wM3phyQkQ+g0Gyjb1GE7k1-bHccQ@mail.gmail.com>
2019-05-15 13:53 ` Roman Stratiienko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAODwZ7t1UgPMeMYcadALD_gCa1Zp1fq65oF9fL65u5DTTft0Sw@mail.gmail.com \
--to=roman.stratiienko@globallogic.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).