From: Fabio Estevam <festevam@gmail.com>
To: Yongcai Huang <Anson.Huang@nxp.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Sascha Hauer <kernel@pengutronix.de>,
Alessandro Zummo <a.zummo@towertech.it>,
alexandre.belloni@bootlin.com,
Dong Aisheng <aisheng.dong@nxp.com>,
Ulf Hansson <ulf.hansson@linaro.org>, Peng Fan <peng.fan@nxp.com>,
Daniel Baluta <daniel.baluta@nxp.com>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>,
"open list:REAL TIME CLOCK (RTC) SUBSYSTEM"
<linux-rtc@vger.kernel.org>, NXP Linux Team <Linux-imx@nxp.com>
Subject: Re: [PATCH 2/3] rtc: imx-sc: Make compatible string more generic
Date: Tue, 11 Jun 2019 17:32:13 -0300 [thread overview]
Message-ID: <CAOMZO5BCuBKHs1jXkm3qFD84_xcB=0NSwE3SLJHx9kq4Stbd_A@mail.gmail.com> (raw)
In-Reply-To: <20190611063333.48501-2-Anson.Huang@nxp.com>
Hi Anson,
On Tue, Jun 11, 2019 at 3:31 AM <Anson.Huang@nxp.com> wrote:
>
> From: Anson Huang <Anson.Huang@nxp.com>
>
> i.MX system controller RTC driver can support all i.MX SoCs
> with system controller inside, this patch makes the compatible
> string more generic to support other i.MX SoCs with system
> controller inside, such as i.MX8QM etc..
>
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> ---
> drivers/rtc/rtc-imx-sc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/rtc/rtc-imx-sc.c b/drivers/rtc/rtc-imx-sc.c
> index c933045..38ef3ca 100644
> --- a/drivers/rtc/rtc-imx-sc.c
> +++ b/drivers/rtc/rtc-imx-sc.c
> @@ -178,7 +178,7 @@ static int imx_sc_rtc_probe(struct platform_device *pdev)
> }
>
> static const struct of_device_id imx_sc_dt_ids[] = {
> - { .compatible = "fsl,imx8qxp-sc-rtc", },
> + { .compatible = "fsl,imx-sc-rtc", },
What is wrong with the current compatible string?
If you want to support i.MX8QM just add in its dtsi:
compatible = "fsl,imx8qm-sc-rtc", "fsl,imx8qxp-sc-rtc"
and add a dt-bindings entry for "fsl,imx8qm-sc-rtc"
next prev parent reply other threads:[~2019-06-11 20:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-11 6:33 [PATCH 1/3] dt-bindings: fsl: scu: Update RTC compatible string Anson.Huang
2019-06-11 6:33 ` [PATCH 2/3] rtc: imx-sc: Make compatible string more generic Anson.Huang
2019-06-11 10:57 ` Aisheng Dong
2019-06-11 19:11 ` Alexandre Belloni
2019-06-11 20:32 ` Fabio Estevam [this message]
2019-06-11 20:45 ` Trent Piepho
2019-06-12 0:48 ` Anson Huang
2019-06-11 6:33 ` [PATCH 3/3] arm64: dts: imx8qxp: Add fallback compatible string for RTC node Anson.Huang
2019-06-11 10:57 ` Aisheng Dong
2019-06-11 10:55 ` [PATCH 1/3] dt-bindings: fsl: scu: Update RTC compatible string Aisheng Dong
2019-07-09 2:28 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOMZO5BCuBKHs1jXkm3qFD84_xcB=0NSwE3SLJHx9kq4Stbd_A@mail.gmail.com' \
--to=festevam@gmail.com \
--cc=Anson.Huang@nxp.com \
--cc=Linux-imx@nxp.com \
--cc=a.zummo@towertech.it \
--cc=aisheng.dong@nxp.com \
--cc=alexandre.belloni@bootlin.com \
--cc=daniel.baluta@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=peng.fan@nxp.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).