From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D17D9C433DB for ; Mon, 15 Mar 2021 21:49:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8D37464EFC for ; Mon, 15 Mar 2021 21:49:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231667AbhCOVtW (ORCPT ); Mon, 15 Mar 2021 17:49:22 -0400 Received: from relay6-d.mail.gandi.net ([217.70.183.198]:44839 "EHLO relay6-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233382AbhCOVtK (ORCPT ); Mon, 15 Mar 2021 17:49:10 -0400 X-Originating-IP: 90.65.108.55 Received: from localhost (lfbn-lyo-1-1676-55.w90-65.abo.wanadoo.fr [90.65.108.55]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id B4301C0004; Mon, 15 Mar 2021 21:49:08 +0000 (UTC) Date: Mon, 15 Mar 2021 22:49:08 +0100 From: Alexandre Belloni To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Cc: Chris Wilson , linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org, Xiaofei Tan , Alessandro Zummo Subject: Re: [PATCH] rtc: cmos: Disable irq around direct invocation of cmos_interrupt() Message-ID: References: <20210305122140.28774-1-chris@chris-wilson.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-rtc@vger.kernel.org On 05/03/2021 15:27:52+0200, Ville Syrjälä wrote: > > which breaks S3-resume on fi-kbl-soraka presumably as that's slow enough > > to trigger the alarm during the suspend. > > > > Fixes: 6950d046eb6e ("rtc: cmos: Replace spin_lock_irqsave with spin_lock in hard IRQ") > > Sigh. I wish people would at least try to check the code/history > before doing these blind "cleanups" :( > Sorry I didn't catch that when applying. I'm usually more wary when getting those kind of cleanups. -- Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com