From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: "Marek Behún" <kabel@kernel.org>
Cc: "Gregory CLEMENT" <gregory.clement@bootlin.com>,
"Arnd Bergmann" <arnd@arndb.de>,
soc@kernel.org, arm@kernel.org,
"Hans de Goede" <hdegoede@redhat.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Bartosz Golaszewski" <brgl@bgdev.pl>,
linux-gpio@vger.kernel.org,
"Alessandro Zummo" <a.zummo@towertech.it>,
"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
linux-rtc@vger.kernel.org,
"Wim Van Sebroeck" <wim@linux-watchdog.org>,
"Guenter Roeck" <linux@roeck-us.net>,
linux-watchdog@vger.kernel.org
Subject: Re: [PATCH v10 2/9] platform: cznic: Add preliminary support for Turris Omnia MCU
Date: Fri, 10 May 2024 18:44:22 +0300 [thread overview]
Message-ID: <Zj5A1qoH-aWbT3XU@smile.fi.intel.com> (raw)
In-Reply-To: <20240510153629.bd3gkfm4he2rybui@kandell>
On Fri, May 10, 2024 at 05:36:29PM +0200, Marek Behún wrote:
> On Fri, May 10, 2024 at 04:41:20PM +0300, Andy Shevchenko wrote:
> > On Fri, May 10, 2024 at 1:18 PM Marek Behún <kabel@kernel.org> wrote:
...
> > > + err = omnia_cmd_read(client, cmd, &reply, sizeof(reply));
> > > + if (!err)
> > > + *dst = le32_to_cpu(reply);
> > > +
> > > + return err;
> >
> > Introduced here and "fixed" in the next patch. Something wrong with
> > rebasing / squashing?
> >
> > You will need a v11 anyway. And you have now much more time for it,
> > don't forget to update the kernel version and date in the ABI
> > documentation.
>
> It would seem so. I will send v11 also with the GPIO changes (to use
> __set_bit() and friends).
I hope it will make v6.11.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-05-10 15:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-10 10:18 [PATCH v10 0/9] Turris Omnia MCU driver Marek Behún
2024-05-10 10:18 ` [PATCH v10 2/9] platform: cznic: Add preliminary support for Turris Omnia MCU Marek Behún
2024-05-10 13:41 ` Andy Shevchenko
2024-05-10 15:36 ` Marek Behún
2024-05-10 15:44 ` Andy Shevchenko [this message]
2024-05-10 10:18 ` [PATCH v10 4/9] platform: cznic: turris-omnia-mcu: Add support for poweroff and wakeup Marek Behún
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zj5A1qoH-aWbT3XU@smile.fi.intel.com \
--to=andy.shevchenko@gmail.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=arm@kernel.org \
--cc=arnd@arndb.de \
--cc=brgl@bgdev.pl \
--cc=gregory.clement@bootlin.com \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=kabel@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=soc@kernel.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).