From: Marek Vasut <marex@denx.de>
To: Bastian Krause <bst@pengutronix.de>, linux-rtc@vger.kernel.org
Cc: Arnaud Ebalard <arno@natisbad.org>,
Alexandre Belloni <alexandre.belloni@free-electrons.com>
Subject: Re: [PATCH V2] rtc: ds1307: Enable battery backup on RX8130
Date: Thu, 21 Nov 2019 09:14:19 +0100 [thread overview]
Message-ID: <ed1ef0a9-ff99-f986-8b9a-e2329bc82761@denx.de> (raw)
In-Reply-To: <3c07a9d4-e28e-df67-8a0b-9a6db48a9dc4@pengutronix.de>
On 11/21/19 9:09 AM, Bastian Krause wrote:
> On 9/5/19 3:03 PM, Marek Vasut wrote:
>> The battery backup can be disabled on this RTC, e.g. if populated right
>> out of production. Force the battery backup bit on to enable it.
>>
>> Signed-off-by: Marek Vasut <marex@denx.de>
>> Cc: Arnaud Ebalard <arno@natisbad.org>
>> Cc: Alexandre Belloni <alexandre.belloni@free-electrons.com>
>> Cc: Bastian Krause <bst@pengutronix.de>
>
> Reviewed-by: Bastian Krause <bst@pengutronix.de>
>
I recall there was some comment about setting BIT(5) as well,
RX8130_REG_CONTROL1_CHGEN , can you check that ?
>
>> ---
>> V2: Drop the custom offset, let regmap handle that
>> ---
>> drivers/rtc/rtc-ds1307.c | 7 +++++++
>> 1 file changed, 7 insertions(+)
>>
>> diff --git a/drivers/rtc/rtc-ds1307.c b/drivers/rtc/rtc-ds1307.c
>> index 1f7e8aefc1eb..f2d1e59478c2 100644
>> --- a/drivers/rtc/rtc-ds1307.c
>> +++ b/drivers/rtc/rtc-ds1307.c
>> @@ -121,6 +121,8 @@ enum ds_type {
>> #define RX8130_REG_FLAG_AF BIT(3)
>> #define RX8130_REG_CONTROL0 0x1e
>> #define RX8130_REG_CONTROL0_AIE BIT(3)
>> +#define RX8130_REG_CONTROL1 0x1f
>> +#define RX8130_REG_CONTROL1_INIEN BIT(4)
>>
>> #define MCP794XX_REG_CONTROL 0x07
>> # define MCP794XX_BIT_ALM0_EN 0x10
>> @@ -1750,6 +1752,11 @@ static int ds1307_probe(struct i2c_client *client,
>> DS1307_REG_HOUR << 4 | 0x08, hour);
>> }
>> break;
>> + case rx_8130:
>> + /* make sure that the backup battery is enabled */
>> + regmap_write(ds1307->regmap, RX8130_REG_CONTROL1,
>> + RX8130_REG_CONTROL1_INIEN);
>> + break;
>> default:
>> break;
>> }
>>
>
>
--
Best regards,
Marek Vasut
next prev parent reply other threads:[~2019-11-21 8:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-05 13:03 [PATCH V2] rtc: ds1307: Enable battery backup on RX8130 Marek Vasut
2019-11-21 8:09 ` Bastian Krause
2019-11-21 8:14 ` Marek Vasut [this message]
2019-11-21 8:21 ` Bastian Krause
2019-11-21 8:28 ` Marek Vasut
2019-11-21 16:39 ` Alexandre Belloni
2019-11-22 9:48 ` Bastian Krause
2019-12-16 11:17 ` Bastian Krause
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed1ef0a9-ff99-f986-8b9a-e2329bc82761@denx.de \
--to=marex@denx.de \
--cc=alexandre.belloni@free-electrons.com \
--cc=arno@natisbad.org \
--cc=bst@pengutronix.de \
--cc=linux-rtc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).