From: Cornelia Huck <cohuck@redhat.com>
To: Pierre Morel <pmorel@linux.ibm.com>
Cc: kvm@vger.kernel.org, linux-s390@vger.kernel.org,
frankja@linux.ibm.com, david@redhat.com, thuth@redhat.com,
imbrenda@linux.ibm.com
Subject: Re: [kvm-unit-tests PATCH v2 4/5] s390x: css: testing measurement block format 0
Date: Fri, 12 Feb 2021 12:12:45 +0100 [thread overview]
Message-ID: <20210212121245.061058ba.cohuck@redhat.com> (raw)
In-Reply-To: <1612963214-30397-5-git-send-email-pmorel@linux.ibm.com>
On Wed, 10 Feb 2021 14:20:13 +0100
Pierre Morel <pmorel@linux.ibm.com> wrote:
> We tests the update of the mesurement block format 0, the
s/tests/test/
s/mesurement/measurement/
> mesurement block origin is calculated from the mbo argument
> used by the SCHM instruction and the offset calculated using
> the measurement block index of the SCHIB.
>
> Signed-off-by: Pierre Morel <pmorel@linux.ibm.com>
> ---
> lib/s390x/css.h | 14 +++++++++++++
> s390x/css.c | 55 +++++++++++++++++++++++++++++++++++++++++++++++++
> 2 files changed, 69 insertions(+)
>
(...)
> +static void test_schm_fmt0(void)
> +{
> + struct measurement_block_format0 *mb0;
> +
> + report_prefix_push("Format 0");
> +
> + mb0 = alloc_io_mem(sizeof(struct measurement_block_format0), 0);
> + if (!mb0) {
> + report_abort("measurement_block_format0 allocation failed");
> + goto end;
> + }
> +
> + schm(NULL, 0); /* Clear previous MB address */
I think it would be better to clean out the mb after a particular test
has run, so that the following tests can start with a clean slate.
> + schm(mb0, SCHM_MBU);
>
> + /* Expect error for non aligned MB */
> + report_prefix_push("Unaligned MB index");
> + report_xfail(start_measure(0, 0x01, false), mb0->ssch_rsch_count != 0,
> + "SSCH measured %d", mb0->ssch_rsch_count);
> + report_prefix_pop();
> +
> + memset(mb0, 0, sizeof(*mb0));
> +
> + /* Expect success */
> + report_prefix_push("Valid MB address and index");
> + report(start_measure(0, 0, false) &&
> + mb0->ssch_rsch_count == SCHM_UPDATE_CNT,
> + "SSCH measured %d", mb0->ssch_rsch_count);
> + report_prefix_pop();
> +
> + free_io_mem(mb0, sizeof(struct measurement_block_format0));
Before you free the memory, you really need to stop measurements
again... even though nothing happens right now, because you're not doing
I/O after this point.
> +end:
> + report_prefix_pop();
> }
>
> static struct {
> @@ -202,6 +256,7 @@ static struct {
> { "enable (msch)", test_enable },
> { "sense (ssch/tsch)", test_sense },
> { "measurement block (schm)", test_schm },
> + { "measurement block format0", test_schm_fmt0 },
> { NULL, NULL }
> };
>
next prev parent reply other threads:[~2021-02-12 11:14 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-10 13:20 [kvm-unit-tests PATCH v2 0/5] CSS Mesurement Block Pierre Morel
2021-02-10 13:20 ` [kvm-unit-tests PATCH v2 1/5] s390x: css: Store CSS Characteristics Pierre Morel
2021-02-12 10:32 ` Cornelia Huck
2021-02-12 15:35 ` Pierre Morel
2021-02-10 13:20 ` [kvm-unit-tests PATCH v2 2/5] s390x: css: simplifications of the tests Pierre Morel
2021-02-12 10:36 ` Cornelia Huck
2021-02-12 15:36 ` Pierre Morel
2021-02-10 13:20 ` [kvm-unit-tests PATCH v2 3/5] s390x: css: implementing Set CHannel Monitor Pierre Morel
2021-02-12 10:53 ` Cornelia Huck
2021-02-12 15:51 ` Pierre Morel
2021-02-10 13:20 ` [kvm-unit-tests PATCH v2 4/5] s390x: css: testing measurement block format 0 Pierre Morel
2021-02-12 11:12 ` Cornelia Huck [this message]
2021-02-12 15:59 ` Pierre Morel
2021-02-10 13:20 ` [kvm-unit-tests PATCH v2 5/5] s390x: css: testing measurement block format 1 Pierre Morel
2021-02-12 11:15 ` Cornelia Huck
2021-02-12 16:04 ` Pierre Morel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210212121245.061058ba.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=pmorel@linux.ibm.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).