From: "Paoloni, Gabriele" <gabriele.paoloni@intel.com>
To: tony.luck@intel.com, bp@alien8.de, tglx@linutronix.de,
mingo@redhat.com, x86@kernel.org, hpa@zytor.com,
linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: gabriele.paoloni@intel.com, linux-safety@lists.elisa.tech
Subject: [linux-safety] [PATCH 3/4] x86/mce: for LMCE panic only if mca_cfg.tolerant < 3
Date: Wed, 18 Nov 2020 15:15:51 +0000 [thread overview]
Message-ID: <20201118151552.1412-4-gabriele.paoloni@intel.com> (raw)
In-Reply-To: <20201118151552.1412-1-gabriele.paoloni@intel.com>
Right now for LMCE if no_way_out is set mce_panic() is called
regardless of mca_cfg.tolerant. This is not correct as if
mca_cfg.tolerant = 3 we should never panic.
Signed-off-by: Gabriele Paoloni <gabriele.paoloni@intel.com>
Reviewed-by: Tony Luck <tony.luck@intel.com>
---
arch/x86/kernel/cpu/mce/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/kernel/cpu/mce/core.c b/arch/x86/kernel/cpu/mce/core.c
index e025ff04438f..d16cbb05b09c 100644
--- a/arch/x86/kernel/cpu/mce/core.c
+++ b/arch/x86/kernel/cpu/mce/core.c
@@ -1367,7 +1367,7 @@ noinstr void do_machine_check(struct pt_regs *regs)
* to see it will clear it.
*/
if (lmce) {
- if (no_way_out)
+ if (no_way_out && mca_cfg.tolerant < 3)
mce_panic("Fatal local machine check", &m, msg);
} else {
order = mce_start(&no_way_out);
--
2.20.1
---------------------------------------------------------------------
INTEL CORPORATION ITALIA S.p.A. con unico socio
Sede: Milanofiori Palazzo E 4
CAP 20094 Assago (MI)
Capitale Sociale Euro 104.000,00 interamente versato
Partita I.V.A. e Codice Fiscale 04236760155
Repertorio Economico Amministrativo n. 997124
Registro delle Imprese di Milano nr. 183983/5281/33
Soggetta ad attivita' di direzione e coordinamento di
INTEL CORPORATION, USA
This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#176): https://lists.elisa.tech/g/linux-safety/message/176
Mute This Topic: https://lists.elisa.tech/mt/78342500/5278000
Group Owner: linux-safety+owner@lists.elisa.tech
Unsubscribe: https://lists.elisa.tech/g/linux-safety/unsub [linux-safety@archiver.kernel.org]
-=-=-=-=-=-=-=-=-=-=-=-
next prev parent reply other threads:[~2020-11-18 15:16 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-18 15:15 [linux-safety] [PATCH 0/4] x86/MCE: some minor fixes Paoloni, Gabriele
2020-11-18 15:15 ` [linux-safety] [PATCH 1/4] x86/mce: do not overwrite no_way_out if mce_end() fails Paoloni, Gabriele
2020-11-20 17:07 ` Borislav Petkov
2020-11-20 17:31 ` Paoloni, Gabriele
2020-11-20 17:33 ` Borislav Petkov
2020-11-23 14:35 ` Borislav Petkov
2020-11-20 17:32 ` Borislav Petkov
2020-11-20 17:35 ` Paoloni, Gabriele
2020-11-18 15:15 ` [linux-safety] [PATCH 2/4] x86/mce: move the mce_panic() call and kill_it assignments at the right places Paoloni, Gabriele
2020-11-23 14:27 ` Borislav Petkov
2020-11-23 17:06 ` Paoloni, Gabriele
2020-11-23 17:19 ` Borislav Petkov
2020-11-23 17:40 ` Paoloni, Gabriele
2020-11-23 18:07 ` Borislav Petkov
2020-11-18 15:15 ` Paoloni, Gabriele [this message]
2020-11-18 15:15 ` [linux-safety] [PATCH 4/4] x86/mce: remove redundant call to irq_work_queue() Paoloni, Gabriele
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201118151552.1412-4-gabriele.paoloni@intel.com \
--to=gabriele.paoloni@intel.com \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-safety@lists.elisa.tech \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).