From: "Lukas Bulwahn" <lukas.bulwahn@gmail.com>
To: linux-safety@lists.elisa.tech
Subject: Re: [PATCH] x86/unwind: remove unneeded initialization
Date: Tue, 20 Oct 2020 09:22:19 +0200 [thread overview]
Message-ID: <CAKXUXMwKn=cP_1DBjnQP8V+8XcHAx+HgEouwqtvHQs1RW2EvSA@mail.gmail.com> (raw)
In-Reply-To: <20201020071952.23794-1-lukas.bulwahn@gmail.com>
On Tue, Oct 20, 2020 at 9:20 AM Lukas Bulwahn <lukas.bulwahn@gmail.com> wrote:
>
> make clang-analyzer on x86_64 defconfig caught my attention with:
>
> arch/x86/kernel/unwind_orc.c:38:7: warning: Value stored to 'mid' during
> its initialization is never read [clang-analyzer-deadcode.DeadStores]
> int *mid = first, *found = first;
> ^
>
> Commit ee9f8fce9964 ("x86/unwind: Add the ORC unwinder") introduced
> __orc_find() with this unneeded dead-store initialization.
>
> Put the variable in local scope and initialize only once the value is
> needed to make clang-analyzer happy.
>
> As compilers will detect these unneeded assignments and optimize this
> anyway, the resulting object code is effectively identical before and
> after this change.
>
> No functional change. Effectively, no change to object code.
>
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> ---
Please help me with your review.
Also help by compiling and comparing the disassembly before and after
with your compiler.
> arch/x86/kernel/unwind_orc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/x86/kernel/unwind_orc.c b/arch/x86/kernel/unwind_orc.c
> index 6a339ce328e0..5c64eed08257 100644
> --- a/arch/x86/kernel/unwind_orc.c
> +++ b/arch/x86/kernel/unwind_orc.c
> @@ -35,7 +35,7 @@ static struct orc_entry *__orc_find(int *ip_table, struct orc_entry *u_table,
> {
> int *first = ip_table;
> int *last = ip_table + num_entries - 1;
> - int *mid = first, *found = first;
> + int *found = first;
>
> if (!num_entries)
> return NULL;
> @@ -47,7 +47,7 @@ static struct orc_entry *__orc_find(int *ip_table, struct orc_entry *u_table,
> * ignored when they conflict with a real entry.
> */
> while (first <= last) {
> - mid = first + ((last - first) / 2);
> + int *mid = first + ((last - first) / 2);
>
> if (orc_ip(mid) <= ip) {
> found = mid;
> --
> 2.17.1
>
next prev parent reply other threads:[~2020-10-20 7:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-20 7:19 [PATCH] x86/unwind: remove unneeded initialization Lukas Bulwahn
2020-10-20 7:22 ` Lukas Bulwahn [this message]
2020-10-28 12:21 Lukas Bulwahn
2020-10-29 2:36 ` Nathan Chancellor
2020-10-29 11:49 ` Walter Harms
2020-10-29 12:04 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKXUXMwKn=cP_1DBjnQP8V+8XcHAx+HgEouwqtvHQs1RW2EvSA@mail.gmail.com' \
--to=lukas.bulwahn@gmail.com \
--cc=linux-safety@lists.elisa.tech \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).