From: "M Tamseel Shams" <m.shams@samsung.com>
To: "'Krzysztof Kozlowski'" <krzysztof.kozlowski@canonical.com>,
<gregkh@linuxfoundation.org>, <jirislaby@kernel.org>
Cc: <linux-arm-kernel@lists.infradead.org>,
<linux-samsung-soc@vger.kernel.org>,
<linux-serial@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<alim.akhtar@samsung.com>
Subject: RE: [PATCH v2] serial: samsung: Checks the return value of function
Date: Mon, 5 Jul 2021 16:34:05 +0530 [thread overview]
Message-ID: <014501d7718d$7a8939e0$6f9bada0$@samsung.com> (raw)
In-Reply-To: <0c608d5e-f59b-3f05-a461-2205cece4b7e@canonical.com>
> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> Sent: Thursday, July 1, 2021 12:06 PM
> To: Tamseel Shams <m.shams@samsung.com>; gregkh@linuxfoundation.org;
> jirislaby@kernel.org
> Cc: linux-arm-kernel@lists.infradead.org; linux-samsung-soc@vger.kernel.org;
> linux-serial@vger.kernel.org; linux-kernel@vger.kernel.org;
> alim.akhtar@samsung.com
> Subject: Re: [PATCH v2] serial: samsung: Checks the return value of function
>
> On 30/06/2021 15:33, Tamseel Shams wrote:
> > "uart_add_one_port" function call may fail and return some error code,
> > so adding a check for return value.
> > If it is returning some error code, then displaying the result,
> > unregistering the driver and then returning from probe function with
> > error code.
> >
> > Signed-off-by: Tamseel Shams <m.shams@samsung.com>
> > ---
> > Changes since v1:
> > 1. Added support to unregister driver on failure of "uart_add_onr_port"
> > function call.
> > 2. Commit message updated.
> >
> > drivers/tty/serial/samsung_tty.c | 11 ++++++++++-
> > 1 file changed, 10 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/tty/serial/samsung_tty.c
> > b/drivers/tty/serial/samsung_tty.c
> > index 9fbc61151c2e..188e2d2da201 100644
> > --- a/drivers/tty/serial/samsung_tty.c
> > +++ b/drivers/tty/serial/samsung_tty.c
> > @@ -2253,7 +2253,11 @@ static int s3c24xx_serial_probe(struct
> platform_device *pdev)
> > }
> >
> > dev_dbg(&pdev->dev, "%s: adding port\n", __func__);
> > - uart_add_one_port(&s3c24xx_uart_drv, &ourport->port);
> > + ret = uart_add_one_port(&s3c24xx_uart_drv, &ourport->port);
> > + if (ret < 0) {
> > + dev_err(&pdev->dev, "Failed to add uart port, err %d\n", ret);
> > + goto add_port_error;
> > + }
> > platform_set_drvdata(pdev, &ourport->port);
> >
> > /*
> > @@ -2272,6 +2276,11 @@ static int s3c24xx_serial_probe(struct
> platform_device *pdev)
> > probe_index++;
> >
> > return 0;
> > +
> > +add_port_error:
>
> You did not unwind fully s3c24xx_serial_init_port() - clocks.
>
Hi Krzysztof,
Yeah, missed the unwinding of clocks.
Will fix this in next version.
Thanks & Regards,
Tamseel Shams
prev parent reply other threads:[~2021-07-05 12:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20210630133115epcas5p1706041f122819d47b18b83853b49694e@epcas5p1.samsung.com>
2021-06-30 13:33 ` [PATCH v2] serial: samsung: Checks the return value of function Tamseel Shams
2021-07-01 6:36 ` Krzysztof Kozlowski
2021-07-05 11:04 ` M Tamseel Shams [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='014501d7718d$7a8939e0$6f9bada0$@samsung.com' \
--to=m.shams@samsung.com \
--cc=alim.akhtar@samsung.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).